954676 - Remove plain text passwords conversion code

Status: RESOLVED FIXED

(Chat Core :: General, task)

Description

[aleth [:aleth]]

*** Original post on bio 1244 at 2012-01-26 00:57:00 UTC ***

http://hg.instantbird.org/instantbird/rev/6dbe0da3ffc4 duplicates the values stored in the preferences in the password manager. When there is no further need for users to be able to switch back to 1.1, these values should be removed.

Comment 1

[Florian Quèze [:florian]]

*** Original post on bio 1244 at 2012-11-02 00:12:41 UTC ***

Too late to work on this for 1.3, replacing 1.3-wanted by 1.4-wanted in the whiteboard.

Comment 2

[Patrick Cloke [:clokep]]

*** Original post on bio 1244 at 2013-04-09 14:49:58 UTC ***

s/1.4-wanted/1.5-wanted/ in the whiteboard for bugs that probably won't happen before 1.4 is released.

Comment 3

[Patrick Cloke [:clokep]]

*** Original post on bio 1244 at 2013-11-02 17:41:55 UTC ***

Mass changing bugs from 1.5-wanted -> 1.6-wanted.

Comment 4

[Patrick Cloke [:clokep]]

(In reply to aleth [:aleth] from comment #0)

*** Original post on bio 1244 at 2012-01-26 00:57:00 UTC ***

http://hg.instantbird.org/instantbird/rev/6dbe0da3ffc4 duplicates the values
stored in the preferences in the password manager. When there is no further
need for users to be able to switch back to 1.1, these values should be
removed.

https://hg.mozilla.org/comm-central/rev/a2a44dff8a5ff8e713da001888ace6f1128ed3ee

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Patch v1

This removes the code for moving plaintext passwords (stored in preferences) to the password manager.

As far as I can tell this code was never active on Thunderbird (this code landed in Instantbird several months before chat was added to Thunderbird and the changes due to bug 953875 have no corresponding mail components). My profile (which is quite old) has no stored passwords in the preferences.

Since this was never used, I've just removed it.

Comment 6

[Martin Giger [:freaktechnik]]

Comment on attachment 9242485 [details] [diff] [review]
Patch v1

Review of attachment 9242485 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3d0ca1865b67
Remove unused code to move plaintext passwords to the password manager. r=freaktechnik