Closed Bug 954702 Opened 10 years ago Closed 10 years ago

Missing keyboard shortcuts for "Put conversation on hold" and "Show logs"

Categories

(Instantbird Graveyard :: Conversation, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

References

Details

(Whiteboard: [1.2-wanted])

Attachments

(1 file)

*** Original post on bio 1271 at 2012-02-15 12:24:00 UTC ***

I think the Escape key should put the currently selected conversation on hold, and the Command+shift+H shortcut could open the logs of similar conversations.
Whiteboard: [1.2-wanted]
*** Original post on bio 1271 at 2012-03-27 17:46:28 UTC ***

(In reply to comment #0)
> I think the Escape key should put the currently selected conversation on hold,
> and the Command+shift+H shortcut could open the logs of similar conversations.

Conversations on hold are hard to reach (you need to go to the contact list, double click them (if not even trying to hit the small target of the unread counter) to restore them. There is no hint what happened when a conversation is put on hold (and neither where it can be found again).
That's why I think that it should not be too easy (possible by accident) to  put a conversation there [*]. The escape key would just be such an easy 'single' key. A combination of a modifier and another key would be less error-prone (since you'd need to press two wrong keys) in my opinion.

Putting on holf and restoring is (hopefully, taking into account the drawbacks mentioned in the beginning) not such a frequent task that it would matter much to hit two keys instead of one.

(Minimizing the conversation window, as we currently have it, is less bad here, since you'll get 'minimize animations' on many OS (which at least show you where the window went). Additionally you'll have a keyboard accessible way to get the window back, except on Mac (according to flo on IRC)


[*] And isn't 'putting on hold' not even getting less important for chats (not MUCs) as soon as bug 954392 (bio 958) is fixed? There'll be context in re-opened/started conversations and you could as well pick the contact from the list as you now do the conversation on hold?
*** Original post on bio 1271 at 2012-03-28 09:35:32 UTC ***

(In reply to comment #2)
> (In reply to comment #0)
> > I think the Escape key should put the currently selected conversation on hold,
> > and the Command+shift+H shortcut could open the logs of similar conversations.
> 
> Conversations on hold are hard to reach (you need to go to the contact list,
> double click them (if not even trying to hit the small target of the unread
> counter) to restore them. There is no hint what happened when a conversation is
> put on hold (and neither where it can be found again).
> That's why I think that it should not be too easy (possible by accident) to 
> put a conversation there [*]. The escape key would just be such an easy
> 'single' key. A combination of a modifier and another key would be less
> error-prone (since you'd need to press two wrong keys) in my opinion.

If I remember correctly, many IM clients (I saw it used with WLM at least) use the Escape key to close the conversation. So "put on hold" is way safer than closing (what users are likely to expect).

> Putting on holf and restoring is (hopefully, taking into account the drawbacks
> mentioned in the beginning) not such a frequent task that it would matter much
> to hit two keys instead of one.

It's not frequent because it's very difficult to do right now (need to look at the context menu, etc...). My conversations on hold currently mostly come from the hide auto-joins add-on.
*** Original post on bio 1271 at 2012-03-28 12:48:31 UTC ***

(In reply to comment #3)
> If I remember correctly, many IM clients (I saw it used with WLM at least) use
> the Escape key to close the conversation. So "put on hold" is way safer than
> closing (what users are likely to expect).

I fail to see a continuing advantage that conversations on hold (for direct IM) will have over (re-)opening a conversation with a contact once bug 954392 (bio 958) is fixed (see [*] in comment 2).

> > Putting on holf and restoring is (hopefully, taking into account the drawbacks
> > mentioned in the beginning) not such a frequent task that it would matter much
> > to hit two keys instead of one.
> 
> It's not frequent because it's very difficult to do right now (need to look at
> the context menu, etc...).

I hope it's getting less frequent once starting a conversation and going back to one will be indistinguishable (i.e. clicking a contact in the list is all you need to do to get the conversation with context/the last session).

> My conversations on hold currently mostly come from
> the hide auto-joins add-on.

It's the only way to keep a MUC (like your auto-joined channels) open without showing the tab for it and it's really useful here. I'm only concerned that we'd over-emphasize this feature in cases where it is not so useful (i.e. for direct IM, once bug 954392 (bio 958) is fixed) while the useful case (hiding a tab of a MUC) is already keyboard accessible.
*** Original post on bio 1271 at 2012-04-14 17:18:01 UTC ***

+1 for a shortcut key for both of these actions.

I agree with some of Mic's points, but that doesn't mean a shortcut won't be useful. Btw bug 954392 (bio 958) is not enough, bug 954567 (bio 1134) (or something like it) would also have to be fixed.
*** Original post on bio 1271 at 2012-06-22 11:21:48 UTC ***

Also suggested on IRC: a shortcut for "close conversation".
Attached patch PatchSplinter Review
*** Original post on bio 1271 as attmnt 1694 at 2012-06-25 22:43:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353451 - Flags: review?(clokep)
Assignee: nobody → florian
Comment on attachment 8353451 [details] [diff] [review]
Patch

*** Original change on bio 1271 attmnt 1694 at 2012-06-26 00:06:16 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353451 - Flags: review?(clokep) → review+
Whiteboard: [1.2-wanted] → [1.2-wanted][checkin-needed]
*** Original post on bio 1271 at 2012-06-26 23:48:06 UTC ***

Fixed in http://hg.instantbird.org/instantbird/rev/42afd9f33fca
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.2-wanted][checkin-needed] → [1.2-wanted]
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.