Launch composer, do EDIT->PREFS Under the pane titled' Recent Pages Menu', type any number ,say, 2323233, inside the textfield. Press OK. The dialog closes. Reopening the dialog stil lshows that value. Shoul we not put a limit to this textfield ?
I wonder if there would be a problem if you entered a really huge number (say 15 digits); I wonder if we'd recognize that as a different number.
OS: Windows NT → All
Hardware: PC → All
over to Charley
Assignee: beppe → cmanske
Severity: normal → minor
Priority: -- → P4
Target Milestone: --- → mozilla1.0
How does a limit of 20 sound?
Status: NEW → ASSIGNED
hmm.. wouldn't 20 make the 'recent pages' menu a little too long ? just my thought...
I would suggest 99 Shrir--remember that users can set this to whatever they want. If I have a reason to want 99 documents in my menu, I may have a good reason!
Sounds ok with me! Note that menus will automatically crop their size and provide a scroll bar if they get too long, so 99 should work.
spam composer change
Component: Editor: Core → Editor: Composer
Trivial to fix.
Whiteboard: EDITORBASE (1/2 DAY)
Target Milestone: mozilla1.0 → mozilla0.9.7
Not important enough for EDITORBASE
Whiteboard: EDITORBASE- (1/2 DAY)
Created attachment 60375 [details] [diff] [review] Validate range of values for recent files menu pref First change in EdDialogCommon.js is in the ValidateNumberRange() method. After discovering that we must use the JS helper "GetString()" instead of "editorShell.GetString()", I fixed all other instances in that file as well.
Keywords: patch, review
Whiteboard: FIX IN HAND, need r=,sr=
Comment on attachment 60375 [details] [diff] [review] Validate range of values for recent files menu pref r=akkana
Attachment #60375 - Flags: review+
Whiteboard: FIX IN HAND, need r=,sr= → FIX IN HAND, need sr=
It's unfortunate to have to suck in three extra (lengthy) js files into this panel just to do this. You could avoid loading editorUtilities.js by instead inserting a <stringbundle/> node and using its 'getString' method. e.g. <stringbundle id="foo" src="mybundle.properties"/> var bundle = document.getElementById("foo"); var myStr = bundle.getString("someKey");
Ben: The other Composer pref panel already included those JS files. We realize that editor does not use the XUL <stringbundle/> pattern, but we do cache the stringbundle service in both nsEditorShell and editorUtilities.js code, so there's probably not a real performance hit.
Also: We need other utility methods in EdDialogCommon.js anyway
Comment on attachment 60375 [details] [diff] [review] Validate range of values for recent files menu pref sr=hewitt
Attachment #60375 - Flags: superreview+
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Verified on Win 2k using build 2001121803.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.