Composer pref takes any number value

VERIFIED FIXED in mozilla0.9.7

Status

SeaMonkey
Composer
P4
minor
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: shrirang khanzode, Assigned: Charles Manske)

Tracking

Trunk
mozilla0.9.7

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: FIX IN HAND, need sr=)

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
Launch composer, do EDIT->PREFS
Under the pane titled' Recent Pages Menu', type any number ,say, 2323233, inside 
the textfield. Press OK. The dialog closes. Reopening the dialog stil lshows 
that value. Shoul we not put a limit to this textfield ?

Comment 1

17 years ago
I wonder if there would be a problem if you entered a really huge number (say 15 
digits); I wonder if we'd recognize that as a different number.
OS: Windows NT → All
Hardware: PC → All

Comment 2

17 years ago
over to Charley
Assignee: beppe → cmanske
Severity: normal → minor
Priority: -- → P4
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 3

17 years ago
How does a limit of 20 sound?
Status: NEW → ASSIGNED
(Reporter)

Comment 4

17 years ago
hmm.. wouldn't 20 make the 'recent pages' menu a little too long ? just my 
thought...

Comment 5

17 years ago
I would suggest 99

Shrir--remember that users can set this to whatever they want.  If I have a 
reason to want 99 documents in my menu, I may have a good reason!
(Assignee)

Comment 6

17 years ago
Sounds ok with me! Note that menus will automatically crop their size and 
provide a scroll bar if they get too long, so 99 should work.

Comment 7

17 years ago
spam composer change
Component: Editor: Core → Editor: Composer
(Assignee)

Comment 8

17 years ago
Trivial to fix.
Whiteboard: EDITORBASE (1/2 DAY)
Target Milestone: mozilla1.0 → mozilla0.9.7

Updated

16 years ago
Whiteboard: EDITORBASE (1/2 DAY) → EDITORBASE- (1/2 DAY)
(Assignee)

Comment 9

16 years ago
Not important enough for EDITORBASE
Whiteboard: EDITORBASE- (1/2 DAY)
(Assignee)

Comment 10

16 years ago
Created attachment 60375 [details] [diff] [review]
Validate range of values for recent files menu pref

First change in EdDialogCommon.js is in the ValidateNumberRange() method.
After discovering that we must use the JS helper "GetString()" instead of
"editorShell.GetString()", I fixed all other instances in that file as well.
(Assignee)

Updated

16 years ago
Keywords: patch, review
Whiteboard: FIX IN HAND, need r=,sr=
(Assignee)

Comment 11

16 years ago
Comment on attachment 60375 [details] [diff] [review]
Validate range of values for recent files menu pref

r=akkana
Attachment #60375 - Flags: review+
(Assignee)

Updated

16 years ago
Whiteboard: FIX IN HAND, need r=,sr= → FIX IN HAND, need sr=
It's unfortunate to have to suck in three extra (lengthy) js files into this
panel just to do this. You could avoid loading editorUtilities.js by instead
inserting a <stringbundle/> node and using its 'getString' method. 

e.g.

<stringbundle id="foo" src="mybundle.properties"/>

var bundle = document.getElementById("foo");
var myStr = bundle.getString("someKey");

(Assignee)

Comment 13

16 years ago
Ben: The other Composer pref panel already included those JS files. 
We realize that editor does not use the XUL <stringbundle/> pattern, but we do
cache the stringbundle service in both nsEditorShell and editorUtilities.js code, 
so there's probably not a real performance hit.
 
(Assignee)

Comment 14

16 years ago
Also: We need other utility methods in EdDialogCommon.js anyway

Comment 15

16 years ago
Comment on attachment 60375 [details] [diff] [review]
Validate range of values for recent files menu pref

sr=hewitt
Attachment #60375 - Flags: superreview+
(Assignee)

Comment 16

16 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 17

16 years ago
Verified on Win 2k using build 2001121803.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.