95471 - Composer pref takes any number value

Status: VERIFIED FIXED

Description

[shrirang khanzode]

Launch composer, do EDIT->PREFS
Under the pane titled' Recent Pages Menu', type any number ,say, 2323233, inside 
the textfield. Press OK. The dialog closes. Reopening the dialog stil lshows 
that value. Shoul we not put a limit to this textfield ?

Comment 1

[Kathleen :Brade]

I wonder if there would be a problem if you entered a really huge number (say 15 
digits); I wonder if we'd recognize that as a different number.

Comment 2

[rubydoo123]

over to Charley

Comment 3

[Charles Manske]

How does a limit of 20 sound?

Comment 4

[shrirang khanzode]

hmm.. wouldn't 20 make the 'recent pages' menu a little too long ? just my 
thought...

Comment 5

[Kathleen :Brade]

I would suggest 99

Shrir--remember that users can set this to whatever they want.  If I have a 
reason to want 99 documents in my menu, I may have a good reason!

Comment 6

[Charles Manske]

Sounds ok with me! Note that menus will automatically crop their size and 
provide a scroll bar if they get too long, so 99 should work.

Comment 7

[Syd Logan]

spam composer change

Comment 8

[Charles Manske]

Trivial to fix.

Comment 9

[Charles Manske]

Not important enough for EDITORBASE

Comment 10

[Charles Manske]

Created attachment 60375 [details] [diff] [review]
Validate range of values for recent files menu pref

First change in EdDialogCommon.js is in the ValidateNumberRange() method.
After discovering that we must use the JS helper "GetString()" instead of
"editorShell.GetString()", I fixed all other instances in that file as well.

Comment 11

[Charles Manske]

Comment on attachment 60375 [details] [diff] [review]
Validate range of values for recent files menu pref

r=akkana

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

It's unfortunate to have to suck in three extra (lengthy) js files into this
panel just to do this. You could avoid loading editorUtilities.js by instead
inserting a <stringbundle/> node and using its 'getString' method. 

e.g.

<stringbundle id="foo" src="mybundle.properties"/>

var bundle = document.getElementById("foo");
var myStr = bundle.getString("someKey");

Comment 13

[Charles Manske]

Ben: The other Composer pref panel already included those JS files. 
We realize that editor does not use the XUL <stringbundle/> pattern, but we do
cache the stringbundle service in both nsEditorShell and editorUtilities.js code, 
so there's probably not a real performance hit.
 

Comment 14

[Charles Manske]

Also: We need other utility methods in EdDialogCommon.js anyway

Comment 15

[Joe Hewitt (gone)]

Comment on attachment 60375 [details] [diff] [review]
Validate range of values for recent files menu pref

sr=hewitt

Comment 16

[Charles Manske]

checked in

Comment 17

[michael wendell]

Verified on Win 2k using build 2001121803.