Closed
Bug 954714
Opened 10 years ago
Closed 10 years ago
Broken offline status
Categories
(Chat Core :: General, defect)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: florian, Assigned: florian)
References
Details
(Whiteboard: [1.2-blocking])
Attachments
(1 file)
4.49 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1282 at 2012-02-24 11:47:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1282 as attmnt 1193 at 2012-02-24 11:47:00 UTC *** Since bug 954193 (bio 759) landed: - when necko thinks the network is offline, the status isn't automatically switched to offline (this is because some code in imCore.js which we never tested doesn't work) - even though it's not possible to connect an account from the account manager while in the offline status, automatic reconnection attempts aren't stopped when the status becomes offline; hence causing connection attempts while necko is offline (change in imAccounts.js). Some additional changes may be needed in socket.jsm to prevent socket connection attempts while offline and/or fail more gracefully, but the changes in the attached patch already fix all the broken situations that I've been able to reliably reproduce without actually putting my laptop into sleep between each test :).
Attachment #8352943 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.2-blocking]
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1282 at 2012-02-24 12:09:03 UTC *** Note: The code to type in the error console to force necko into offline mode is: Components.utils.import("resource://gre/modules/Services.jsm"); Services.io.manageOfflineStatus = false; Services.io.offline = true;
Comment 3•10 years ago
|
||
Comment on attachment 8352943 [details] [diff] [review] Patch *** Original change on bio 1282 attmnt 1193 at 2012-02-24 12:58:14 UTC *** This change looks fine.
Attachment #8352943 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1282 at 2012-02-24 15:35:57 UTC *** https://hg.instantbird.org/instantbird/rev/7b6b8b43889e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•