Closed Bug 954738 Opened 10 years ago Closed 10 years ago

Joining a password protected IRC channel via password set in autojoin doesn't work from Feb 28 nightly

Categories

(Chat Core :: IRC, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: clokep)

Details

(Whiteboard: [1.2-blocking])

Attachments

(1 file)

*** Original post on bio 1306 by Gary Kwong [:gkw, :nth10sd] <gary AT rumblingedge.com> at 2012-03-01 23:42:00 UTC ***

Joining a password protected IRC channel via password set in autojoin portion of Tools->Accounts->Properties of IRC account, doesn't work from Feb 28 nightly.

Works on Feb 27 nightly. Last tested on Lion Mac OS X 10.7.
*** Original post on bio 1306 at 2012-03-02 00:13:19 UTC ***

This should be as simple as adding a .split(" ") wherever we get the list of autojoin rooms...

Thanks for reporting this.
*** Original post on bio 1306 at 2012-03-03 13:59:54 UTC ***

I've checked and can confirm this problem.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [1.2-blocking]
Attached patch PatchSplinter Review
*** Original post on bio 1306 as attmnt 1327 at 2012-04-10 23:52:00 UTC ***

I wish the two places that the join code is done could use the same code path, but I don't see an easy way to do that.
Attachment #8353080 - Flags: review?(bugzilla)
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment on attachment 8353080 [details] [diff] [review]
Patch

*** Original change on bio 1306 attmnt 1327 at 2012-04-11 16:16:27 UTC ***

Looks good :)

Btw, is this feature documented anywhere? (ie. how would one discover it exists?)
Attachment #8353080 - Flags: review?(bugzilla) → review+
*** Original post on bio 1306 at 2012-04-11 17:11:35 UTC ***

(In reply to comment #4)
> Comment on attachment 8353080 [details] [diff] [review] (bio-attmnt 1327) [details]
> Patch
> 
> Looks good :)
> 
> Btw, is this feature documented anywhere? (ie. how would one discover it
> exists?)
It's not really supported, someone asked about it over IRC, I checked the libpurple IRC code and saw it just sent the whole textbox as a command to the server, so...it would work). Anyway, we need to support it still since some people are using it! :)
Whiteboard: [1.2-blocking] → [1.2-blocking][checkin-needed]
*** Original post on bio 1306 at 2012-04-13 00:08:21 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/bd43e9c70bc3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.2-blocking][checkin-needed] → [1.2-blocking]
Target Milestone: --- → 1.2
*** Original post on bio 1306 by gary AT rumblingedge.com at 2012-04-14 19:13:53 UTC ***

Verified fixed in:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0) Gecko/20120413 Instantbird/1.2a1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.