Closed
Bug 954760
Opened 10 years ago
Closed 10 years ago
/msg <nick> should open an empty conversation tab
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(2 files)
607 bytes,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
898 bytes,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1328 at 2012-03-08 20:10:00 UTC *** rather than failing, see bug 954759 (bio 1327). Similarly for /query.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1328 as attmnt 1236 at 2012-03-09 01:18:00 UTC *** Does what it says on the tin, hopefully.
Attachment #8352989 -
Flags: review?(clokep)
Comment 2•10 years ago
|
||
Comment on attachment 8352989 [details] [diff] [review] Patch *** Original change on bio 1328 attmnt 1236 at 2012-03-09 01:23:35 UTC *** Looks good, thanks for taking care of this! :) I do feel like this function could be made simpler by a usage of trim...but that's not in the scope of this bug.
Attachment #8352989 -
Flags: review?(clokep) → review+
Comment 3•10 years ago
|
||
*** Original post on bio 1328 at 2012-03-12 23:54:03 UTC *** Checked in as http://hg.instantbird.org/instantbird/rev/2ea0ec22990e Thanks for fixing this up!
Assignee: nobody → aleth
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1328 as attmnt 1255 at 2012-03-15 20:46:00 UTC *** (Followup) Fixes an error that occurs on "/msg nick " due to the whitespace at the end.
Attachment #8353008 -
Flags: review?(clokep)
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 1328 at 2012-03-15 20:46:57 UTC *** (Because it didn't reopen automatically.)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•10 years ago
|
||
Comment on attachment 8353008 [details] [diff] [review] Followup patch *** Original change on bio 1328 attmnt 1255 at 2012-03-15 21:57:02 UTC *** This worked in every case I could throw at it and seems sufficiently simple.
Attachment #8353008 -
Flags: review?(clokep) → review+
Updated•10 years ago
|
Hardware: x86 → All
Whiteboard: [checkin-needed]
Comment 7•10 years ago
|
||
*** Original post on bio 1328 at 2012-03-20 22:38:06 UTC *** (In reply to comment #6) > Comment on attachment 8353008 [details] [diff] [review] (bio-attmnt 1255) [details] > Followup patch > > This worked in every case I could throw at it and seems sufficiently simple. Checked in as http://hg.instantbird.org/instantbird/rev/d8f6bac791f9 Thanks (again)!
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
You need to log in
before you can comment on or make changes to this bug.
Description
•