Closed
Bug 954761
Opened 10 years ago
Closed 10 years ago
Tab complete: prefer sender of the last ping
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file, 1 obsolete file)
2.71 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1329 at 2012-03-08 23:26:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1329 as attmnt 1233 at 2012-03-08 23:26:00 UTC *** Give preference to whoever last mentioned the user's nick on tab complete (even if that nick is not active, or if there are other active nick completions).
Attachment #8352986 -
Flags: review?(florian)
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8352986 [details] [diff] [review] Patch *** Original change on bio 1329 attmnt 1233 at 2012-03-09 19:00:06 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352986 -
Flags: review?(florian)
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1329 as attmnt 1237 at 2012-03-09 21:47:00 UTC *** Only prefer the last ping sender if the ping was less than an hour ago.
Attachment #8352990 -
Flags: review?(florian)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8352986 [details] [diff] [review] Patch *** Original change on bio 1329 attmnt 1233 at 2012-03-09 21:47:43 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352986 -
Attachment is obsolete: true
Comment 5•10 years ago
|
||
Comment on attachment 8352990 [details] [diff] [review] Patch *** Original change on bio 1329 attmnt 1237 at 2012-04-03 21:36:19 UTC *** r=me, I'm removing the unrelated line (let secondNick = false;) and changing 60 * 60 to 3600 before the check-in.
Attachment #8352990 -
Flags: review?(florian) → review+
Comment 6•10 years ago
|
||
*** Original post on bio 1329 at 2012-04-04 10:32:14 UTC *** Checked in as http://hg.instantbird.org/instantbird/rev/8a57df6e1529 Thanks for working on this!
Assignee: nobody → aleth
Status: NEW → RESOLVED
Closed: 10 years ago
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•