954761 - Tab complete: prefer sender of the last ping

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1329 at 2012-03-08 23:26:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1329 as attmnt 1233 at 2012-03-08 23:26:00 UTC ***

Give preference to whoever last mentioned the user's nick on tab complete (even if that nick is not active, or if there are other active nick completions).

Comment 2

[aleth [:aleth]]

Comment on attachment 8352986 [details] [diff] [review]
Patch

*** Original change on bio 1329 attmnt 1233 at 2012-03-09 19:00:06 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1329 as attmnt 1237 at 2012-03-09 21:47:00 UTC ***

Only prefer the last ping sender if the ping was less than an hour ago.

Comment 4

[aleth [:aleth]]

Comment on attachment 8352986 [details] [diff] [review]
Patch

*** Original change on bio 1329 attmnt 1233 at 2012-03-09 21:47:43 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8352990 [details] [diff] [review]
Patch

*** Original change on bio 1329 attmnt 1237 at 2012-04-03 21:36:19 UTC ***

r=me, I'm removing the unrelated line (let secondNick = false;) and changing 60 * 60 to 3600 before the check-in.

Comment 6

[Patrick Cloke [:clokep]]

*** Original post on bio 1329 at 2012-04-04 10:32:14 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/8a57df6e1529

Thanks for working on this!