954777 - stop using XPCOM proxies in purpleSockets

Status: RESOLVED FIXED

(Chat Core :: Eventloop, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1344 at 2012-03-17 11:46:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

*** Original post on bio 1344 as attmnt 1259 at 2012-03-17 11:46:00 UTC ***

...as XPCOM proxies have been removed from Mozilla 12.

I have a patch that uses an nsIRunnable instead of the XPCOM proxy, it seems to work.

Now that we no longer use the proxy, I don't see any use for the purpleISocket xpcom interface, and I think we should deCOMify. Not sure if it should be in the same check-in or not though.

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch + deCOM

*** Original post on bio 1344 as attmnt 1260 at 2012-03-17 12:04:00 UTC ***

Same as attachment 8353012 [details] [diff] [review] (bio-attmnt 1259) + some straight forward deCOMification. If we really want, we can go further by removing the Init methods, but I'm not sure it's worth the additional effort.

Comment 3

[Florian Quèze [:florian]]

Attachment: Patch v3

*** Original post on bio 1344 as attmnt 1261 at 2012-03-17 12:10:00 UTC ***

Bah... I forgot to remove the SetPollFlags method in the 2 previous patches...

Comment 4

[Patrick Cloke [:clokep]]

*** Original post on bio 1344 at 2012-03-19 12:58:32 UTC ***

(In reply to comment #0)
> Now that we no longer use the proxy, I don't see any use for the purpleISocket
> xpcom interface, and I think we should deCOMify. Not sure if it should be in
> the same check-in or not though.

I agree that it doesn't seem necessary, the same check-in is fine with me if it reduces the work.

(In reply to comment #2)
> Created attachment 8353014 [details] [diff] [review] (bio-attmnt 1261) [details]
> Patch v3
> Bah... I forgot to remove the SetPollFlags method in the 2 previous patches...

I looked over this briefly and I don't see any major gotchas, but I won't pretend to fully understand all of this code. :)

Comment 5

[Patrick Cloke [:clokep]]

*** Original post on bio 1344 at 2012-03-20 22:41:50 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/62fad134aa55