Closed
Bug 954785
Opened 10 years ago
Closed 10 years ago
Tray icon missing after moz11 update
Categories
(Instantbird Graveyard :: Other, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: aleth, Assigned: florian)
References
Details
(Whiteboard: [1.2-wanted])
Attachments
(1 file)
6.08 KB,
image/png
|
Details |
*** Original post on bio 1351 at 2012-03-23 19:58:00 UTC *** The tray icon is missing or not displayed properly (transparent).
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1351 at 2012-03-24 00:04:42 UTC *** I ported this fix: https://github.com/nmaier/mintrayr/commit/82434ec2dbbd583860f14f0fc2e3da378de959ab https://hg.instantbird.org/instantbird/rev/e54b1858ed0c
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
Reporter | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1351 as attmnt 1270 at 2012-03-24 16:43:00 UTC *** Not completely fixed as for some reason the icon isn't set use the correct size.
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8353023 [details]
Screenshot
*** Original change on bio 1351 attmnt 1270 at 2012-03-24 16:45:51 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353023 -
Attachment is patch: false
Attachment #8353023 -
Attachment mime type: text/plain → image/png
Reporter | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1351 at 2012-03-24 17:44:19 UTC *** -
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 5•10 years ago
|
||
*** Original post on bio 1351 at 2012-04-01 16:26:35 UTC *** Is it possible this is simply due to there being no 24x24 icon in instantbird/branding? One could fairly easily check this by adding such an icon to http://lxr.instantbird.org/instantbird/source/instantbird/branding/nightly/gtk/ by shrinking the 48x48 icon by 50%.
Whiteboard: [1.2-wanted]
Reporter | ||
Comment 6•10 years ago
|
||
*** Original post on bio 1351 at 2012-04-01 16:36:25 UTC *** Hmm, the correct size may be 22x22 (also a standard I believe). Hard to believe gtk can't resize the 48x48 one correctly on the fly.
Assignee | ||
Comment 7•10 years ago
|
||
*** Original post on bio 1351 at 2012-04-02 13:54:23 UTC *** You can use strace to see if an attempt to read such an icon file is made. I usually do that with this command: LD_LIBRARY_PATH=. strace ./instantbird-bin 2>&1 |grep ENOENT
Reporter | ||
Comment 8•10 years ago
|
||
*** Original post on bio 1351 at 2012-04-02 19:46:18 UTC *** (In reply to comment #6) > You can use strace to see if an attempt to read such an icon file is made. > I usually do that with this command: > LD_LIBRARY_PATH=. strace ./instantbird-bin 2>&1 |grep ENOENT Great idea! Looking at the ENOENT calls first, after a whole lot of stat64 calls on GTK icon themes (probably to check if there is an icon present which would override the one provided by the app), there is [pid 29514] access(".../instantbird/chrome/icons/default/default32.png", R_OK) = -1 ENOENT (No such file or directory) [pid 29514] access(".../instantbird/chrome/icons/default/default32.png", R_OK) = -1 ENOENT (No such file or directory) similarly for blistWindow32.png and convWindow32.png. Checking what happens including non-failed calls (for the blist example) one finds in sequence [pid 30937] access(".../instantbird/chrome/icons/default/blistWindow.png", R_OK) = 0 [pid 30937] open(".../instantbird/chrome/icons/default/blistWindow.png", O_RDONLY|O_LARGEFILE) = 3 [pid 30937] fstat64(3, {st_mode=S_IFREG|0755, st_size=2272, ...}) = 0 [pid 30937] mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xb2000000 [pid 30937] read(3, "\211PNG\r\n\32\n\0\0\0\rIHDR\0\0\0 \0\0\0 \10\6\0\0\0szz"..., 4096) = 2272 [pid 30937] read(3, "", 4096) = 0 ... [pid 30937] access(".../instantbird/chrome/icons/default/blistWindow16.png", R_OK) = 0 [pid 30937] open(".../instantbird/chrome/icons/default/blistWindow16.png", O_RDONLY|O_LARGEFILE) = 3 [pid 30937] fstat64(3, {st_mode=S_IFREG|0755, st_size=886, ...}) = 0 [pid 30937] mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xb2000000 [pid 30937] read(3, "\211PNG\r\n\32\n\0\0\0\rIHDR\0\0\0\20\0\0\0\20\10\6\0\0\0\37\363\377"..., 4096) = 886 [pid 30937] read(3, "", 4096) = 0 ... [pid 30937] access(".../instantbird/chrome/icons/default/blistWindow.png", R_OK) = 0 [pid 30937] open(".../instantbird/chrome/icons/default/blistWindow.png", O_RDONLY|O_LARGEFILE) = 3 [pid 30937] fstat64(3, {st_mode=S_IFREG|0755, st_size=2272, ...}) = 0 [pid 30937] mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xb2000000 [pid 30937] read(3, "\211PNG\r\n\32\n\0\0\0\rIHDR\0\0\0 \0\0\0 \10\6\0\0\0szz"..., 4096) = 2272 [pid 30937] read(3, "", 4096) = 0 ... [pid 30937] access(".../instantbird/chrome/icons/default/blistWindow32.png", R_OK) = -1 ENOENT (No such file or directory) [pid 30937] access(".../teststyles/next/chrome/icons/default/blistWindow32.png", R_OK) = -1 ENOENT (No such file or directory) [pid 30937] access(".../teststyles/multiroot/chrome/icons/default/blistWindow32.png", R_OK) = -1 ENOENT (No such file or directory) [pid 30937] access(".../teststyles/simple/chrome/icons/default/blistWindow32.png", R_OK) = -1 ENOENT (No such file or directory) [pid 30937] access(".../instantbird/chrome/icons/default/blistWindow32.png", R_OK) = -1 ENOENT (No such file or directory) [pid 30937] access(".../instantbird/chrome", F_OK) = 0 [pid 30937] access(".../teststyles/next/chrome", F_OK) = 0 [pid 30937] access(".../teststyles/multiroot/chrome", F_OK) = 0 [pid 30937] access(".../teststyles/simple/chrome", F_OK) = 0 [pid 30937] access(".../instantbird/chrome/icons/default/blistWindow48.png", R_OK) = 0 [pid 30937] open(".../instantbird/chrome/icons/default/blistWindow48.png", O_RDONLY|O_LARGEFILE) = 3 [pid 30937] fstat64(3, {st_mode=S_IFREG|0755, st_size=3911, ...}) = 0 [pid 30937] mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xb2000000 [pid 30937] read(3, "\211PNG\r\n\32\n\0\0\0\rIHDR\0\0\0000\0\0\0000\10\6\0\0\0W\2\371"..., 4096) = 3911 [pid 30937] read(3, "", 4096) = 0 This is a bit inconclusive, as it seems to find (and also at some point load) all the icon sizes that are present, and opens the 48x48 icon after failing to find the 32x32 one. It never seems to look for a 22 or 24 size icon.
Reporter | ||
Comment 9•10 years ago
|
||
*** Original post on bio 1351 at 2012-04-02 22:29:17 UTC *** I think this might be a GTK-Apps-in-KDE issue. Evidence: - Pidgin seems to have the same problem. - I don't see the problem when in Gnome 2.x. Can anyone confirm this with a more current version of Gnome, and possibly check it still happens with the latest KDE too?
Reporter | ||
Comment 10•10 years ago
|
||
*** Original post on bio 1351 at 2012-04-17 19:23:53 UTC *** Reported as working fine on gnome 3 by Tomek on IRC, and confirmed on gnome 2. So it does seem like the KDE tray doesn't use the right size icon when the gtk app sets the icon via its name. Hopefully they will fix this...
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•