Closed Bug 954807 Opened 10 years ago Closed 10 years ago

CTCP ERRMSG is handled poorly

Categories

(Chat Core :: IRC, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

Details

Attachments

(1 file)

*** Original post on bio 1373 at 2012-04-12 23:39:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
*** Original post on bio 1373 as attmnt 1340 at 2012-04-12 23:39:00 UTC ***

Currently if another client fails to parse our CTCP command we get an ERRMSG response which we handle very poorly (as seen in bug 954758 (bio 1326) comment 1):

(In reply to bug 954758 (bio 1326) comment #1)
> I can confirm this. Also, the error console has four errors,
> Error: [object Object]
> Source File: resource:///modules/ircCTCP.jsm
> Line: 170
> Source Code:
> irc

We should probably throw a warning in the error console (similar to what we do for an unhandled IRC message).

Note that this is fairly easily reproducible with the STR in bug 954758 (bio 1326) comment 0, but that the patch there will hide this issue.
Attachment #8353093 - Flags: review?(florian)
Comment on attachment 8353093 [details] [diff] [review]
Add a warning message

*** Original change on bio 1373 attmnt 1340 at 2012-04-12 23:58:17 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353093 - Flags: review?(florian) → review+
*** Original post on bio 1373 at 2012-04-13 00:05:45 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/9562d0640b13
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.