Closed Bug 954824 Opened 10 years ago Closed 10 years ago

Warning: reference to undefined property this._lastScrollHeight

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(2 files, 2 obsolete files)

*** Original post on bio 1389 at 2012-04-23 12:16:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1389 as attmnt 1381 at 2012-04-23 12:16:00 UTC ***

JavaScript strict warning: chrome://chat/content/convbrowser.xml, line 565: reference to undefined property this._lastScrollHeight

Only ever referenced in this method, so while I am not sure when this happens, this seems the obvious fix.
Attachment #8353134 - Flags: review?(florian)
*** Original post on bio 1389 at 2012-04-23 12:24:01 UTC ***

Assigning to aleth.
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Hardware: x86 → All
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1389 as attmnt 1382 at 2012-04-23 19:40:00 UTC ***

typeof -> in
Attachment #8353135 - Flags: review?(florian)
Comment on attachment 8353134 [details] [diff] [review]
Patch

*** Original change on bio 1389 attmnt 1381 at 2012-04-23 19:40:06 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353134 - Attachment is obsolete: true
Attachment #8353134 - Flags: review?(florian)
Attached patch PatchSplinter Review
*** Original post on bio 1389 as attmnt 1383 at 2012-04-23 19:41:00 UTC ***

missing !
Attachment #8353136 - Flags: review?(florian)
Comment on attachment 8353135 [details] [diff] [review]
Patch

*** Original change on bio 1389 attmnt 1382 at 2012-04-23 19:41:23 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353135 - Attachment is obsolete: true
Attachment #8353135 - Flags: review?(florian)
Comment on attachment 8353136 [details] [diff] [review]
Patch

*** Original change on bio 1389 attmnt 1383 at 2012-04-24 16:45:30 UTC ***

This change looks fine to me.
Attachment #8353136 - Flags: review?(florian) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1389 at 2012-04-24 22:48:53 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/2eeb8a68d5a3 thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
*** Original post on bio 1389 as attmnt 1404 at 2012-04-25 19:05:00 UTC ***

Fixes the broken patch that landed.
Attachment #8353157 - Flags: review?(florian)
*** Original post on bio 1389 at 2012-04-25 19:05:59 UTC ***

Status change
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8353157 [details] [diff] [review]
Patch to fix bustage

*** Original change on bio 1389 attmnt 1404 at 2012-04-25 21:32:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353157 - Flags: review?(florian) → review+
*** Original post on bio 1389 at 2012-04-26 00:13:10 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/3b67cfcfc0ad
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
You need to log in before you can comment on or make changes to this bug.