Closed
Bug 954830
Opened 10 years ago
Closed 10 years ago
[Tab Complete] Cycling backwards through list of completions
Categories
(Instantbird Graveyard :: Conversation, enhancement)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: benediktp, Assigned: aleth)
Details
Attachments
(2 files)
1.53 KB,
patch
|
Details | Diff | Splinter Review | |
1.55 KB,
patch
|
clokep
:
review+
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1395 at 2012-04-24 12:24:00 UTC *** Cycling backwards could be useful in some cases. http://log.bezut.info/instantbird/120424/#m249 Suggestion: use Shift as modifier for reversing the direction. This is similiar to the cycling behaviour through tabs in Firefox (or MDI applications on Windows in general) with Ctrl+Tab/Ctrl+Shift+Tab, Window cycling with Alt+Tab/Alt+Shift+Tab or moving the focus forward/backward with Tab/Shift+Tab.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1395 as attmnt 1388 at 2012-04-24 16:12:00 UTC *** Unfortunately this patch isn't pretty, because % doesn't map negative numbers to positive numbers, and because this._completionsIndex points at the next completion to be used in the forward cycle direction. (I think changing all the code to have this._completionsIndex point at the last completion used wouldn't make things better, because there may be none when the completion was partial).
Attachment #8353141 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1395 as attmnt 1389 at 2012-04-24 16:29:00 UTC *** This looks better.
Attachment #8353142 -
Flags: review?(clokep)
Comment 3•10 years ago
|
||
Comment on attachment 8353142 [details] [diff] [review] Patch with less duplication *** Original change on bio 1395 attmnt 1389 at 2012-04-24 16:36:15 UTC *** This looks good, and is much simpler than the previous patch! :) I don't know this code super well, so flo probably wants to take a passing glance at this before checking it in.
Attachment #8353142 -
Flags: review?(clokep) → review+
Updated•10 years ago
|
Attachment #8353142 -
Flags: review?(florian)
Comment 4•10 years ago
|
||
Comment on attachment 8353141 [details] [diff] [review] Patch *** Original change on bio 1395 attmnt 1388 at 2012-04-24 16:36:45 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353141 -
Flags: review?(florian)
Comment 5•10 years ago
|
||
Comment on attachment 8353142 [details] [diff] [review] Patch with less duplication *** Original change on bio 1395 attmnt 1389 at 2012-04-24 21:12:25 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353142 -
Flags: review?(florian) → review+
Comment 6•10 years ago
|
||
*** Original post on bio 1395 at 2012-04-24 22:49:43 UTC *** Checked in as http://hg.instantbird.org/instantbird/rev/1536cef6bff6 Can't wait to try this!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•