954832 - [Tab complete] Don't print endlessly long list of possible completions

Status: RESOLVED WONTFIX

(Instantbird Graveyard :: Conversation, enhancement)

Description

[aleth [:aleth]]

*** Original post on bio 1397 at 2012-04-24 20:00:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1397 as attmnt 1394 at 2012-04-24 20:00:00 UTC ***

The list of partial completions printed to a system message can get very long, in fact far too long to be usefully read imho. Therefore I propose something along the lines of this patch, which only lists the first 10 nicks, plus the number of available completions.

Is this wanted?

Asking for review, but this patch is *NOT* ready to land as it requires localization and I am not sure where to add the string.

Comment 2

[Patrick Cloke [:clokep]]

*** Original post on bio 1397 at 2012-04-24 20:04:27 UTC ***

Comment on attachment 8353147 [details] [diff] [review] (bio-attmnt 1394)
Patch

Not the perfect place, but http://lxr.instantbird.org/instantbird/source/chat/locales/en-US/commands.properties sounds OKish to me. flo, what do you think?

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 1397 at 2012-04-24 20:47:26 UTC ***

(In reply to comment #0)

> Is this wanted?

I don't care strongly either way.

> 
> Asking for review, but this patch is *NOT* ready to land as it requires
> localization and I am not sure where to add the string.

Localization of a plural formated string. https://developer.mozilla.org/en/Localization_and_Plurals

(In reply to comment #1)
> Not the perfect place, but
> http://lxr.instantbird.org/instantbird/source/chat/locales/en-US/commands.properties
> sounds OKish to me. flo, what do you think?

In chat/ for a string in instantbird/? Want Thunderbird localizers to kill me? :-D
But if you extract the completion code to a JS module in chat/ (and add unit tests for it), then it would be fine there :-).
You would probably need to move the 'active' boolean to the prplIConvChatBuddy interface, but I guess that would help me for another Thunderbird bug :).

Otherwise, I would put it in the catchall instantbird.properties for now.

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8353147 [details] [diff] [review]
Patch

*** Original change on bio 1397 attmnt 1394 at 2012-04-24 20:50:19 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[aleth [:aleth]]

*** Original post on bio 1397 at 2012-04-24 21:16:08 UTC ***

flo pointed out the full list of completions of "/" is helpful.

Comment 6

[aleth [:aleth]]

*** Original post on bio 1397 at 2012-06-25 21:11:31 UTC ***

This is not the better UI display of possible completions that would be wanted.