Closed Bug 954834 Opened 10 years ago Closed 10 years ago

[Tab complete] Don't add trailing space to completions in the middle of the line

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(1 file)

*** Original post on bio 1399 at 2012-04-24 23:40:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch PatchSplinter Review
*** Original post on bio 1399 as attmnt 1400 at 2012-04-24 23:40:00 UTC ***

As discussed on IRC, there is not really a good reason to add a trailing space after the completion if it happens in the middle of a line rather than at the beginning (where you want a suffix). In normal sentences, you may want to follow the nick by punctuation. And as for any other typed word, it is natural to follow it by pressing space, if one isn't used to the present tab complete behaviour.

We should test this simple change and see what it feels like.
Attachment #8353153 - Flags: review?(florian)
Comment on attachment 8353153 [details] [diff] [review]
Patch

*** Original change on bio 1399 attmnt 1400 at 2012-04-24 23:41:47 UTC ***

I like the one character patches. :)
Attachment #8353153 - Flags: review?(florian) → review+
Hardware: x86 → All
Whiteboard: [checkin-needed]
*** Original post on bio 1399 at 2012-04-26 00:14:26 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/1ba4dffd7c74 Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.