Closed Bug 954840 Opened 10 years ago Closed 10 years ago

Reply-to-nick: Multiple nicks and compatibility with tab complete

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(2 files)

*** Original post on bio 1406 at 2012-04-26 22:21:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch PatchSplinter Review
*** Original post on bio 1406 as attmnt 1407 at 2012-04-26 22:21:00 UTC ***

- Produce comma-separated list if there are already leading nicks
- Clear tab completions so subsequent backspace doesn't undo everything (i.e. treat double-click just as any other key press).
Attachment #8353160 - Flags: review?(florian)
Comment on attachment 8353160 [details] [diff] [review]
Patch

*** Original change on bio 1406 attmnt 1407 at 2012-04-29 23:01:49 UTC ***

Seems good (but I haven't tested it).
Attachment #8353160 - Flags: review?(florian) → review+
*** Original post on bio 1406 at 2012-04-29 23:06:23 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/9214cc27c3f9 Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
Attached patch PatchSplinter Review
*** Original post on bio 1406 as attmnt 1421 at 2012-04-30 11:07:00 UTC ***

Followup: don't reply to nick if the nick is already being pinged.
Attachment #8353173 - Flags: review?(florian)
Comment on attachment 8353173 [details] [diff] [review]
Patch

*** Original change on bio 1406 attmnt 1421 at 2012-04-30 11:12:18 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353173 - Flags: review?(florian) → review+
*** Original post on bio 1406 at 2012-05-01 11:00:14 UTC ***

Comment on attachment 8353173 [details] [diff] [review] (bio-attmnt 1421)
Patch

https://hg.instantbird.org/instantbird/rev/42dfeac069b7
You need to log in before you can comment on or make changes to this bug.