954846 - [Stopwatch] Stopwatch becomes negative after changing the date (one day earlier)

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Bingqing Li]

Environments:
----------------------------
v1.3
Gaia      01e9da49be2cc4bc134eeefc434740d572ec2246
Gecko     http://hg.mozilla.org/releases/mozilla-aurora/rev/af28fe58e263
BuildID   20131224004001
Version   28.0a2

v1.2
Gaia      724d36716bcbbc5cee1af18b94cc328c289d0ccc
Gecko     http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/931864adcf68
BuildID   20131224004001
Version   26.0


Steps to reproduce:
---------------------------
1. Goto clock
2. Start stopwatch
3. Press "Home" button
4. Goto setting, change the date 
   e.g. Current date is Dec 30,2013, change the date to Dec 29 2013
5. Go back to clock—stopwatch


Actual results:
----------------------------
The numbers of stopwatch become negative.

Comment 1

[amitav.anand]

This is reproducible on ZTE device. Also the phone crashes after the test and does not boot up. Re flashing(make reset-gaia) the phone is the only option to bring back the phone.
Device: ZTE
Hardware revision : roamer2
OS version : 1.4.0.0-prerelease
BuildID: 20131227113200
Git Commit Info:2013-12-18 21:39:18 8bbb5170.

Reproducible on Nexus4. Phone doesn't crash in Nexus4.
Device: Nexus 4
Hardware revision : mako
OS version : 1.4.0.0-prerelease
BuildID: 20131226105855
Git Commit Info:2014-01-10 04:23:01 1125ca30

Will start analyzing the issue.

Comment 2

[Dylan Oliver [:doliver]]

triage: not blocking. this one is reproducible but the expectation is that most users will get time automatically from service providers.

Comment 3

[Dylan Oliver [:doliver]]

triage: not blocking. this one is reproducible but the expectation is that most users will get time automatically from service providers.

Comment 4

[Rachelle Yang [:ryang][[e-mail]]]

Hi Marcus, Would you please kindly look into the bug which is requested by partner ?

Thank you very much!

Comment 5

[Vishnu Dangi]

Attachment: stopwatch_become_negative

Our approach is when we change time through setting app then "moztimechange" event is occur and as per current time we changed startime of stopwatch.
please review this and give your feedback.

Comment 6

[Veeresh]

Few observation on the patch.
1. When the clock application is put in the background by pressing home button. 
getElapsed time is called less frequent. With this when the moztimechange event handled is called it will get a stale elapsed time value. This will work fine in normal case because there is no change in date. However when the user changes date it the value is not accurate.

2. When the clock application is put in the background and user press the power button. Again getElapsed time function is very less frequent.

Comment 7

[Rachelle Yang [:ryang][[e-mail]]]

Hi Marcus, would you please kindly review the patch for us ? 
Thank you very much !

Comment 8

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8511607 [details] [diff] [review]
stopwatch_become_negative

If you've tested that this works, it's good for me, but please change the variable "currentElspseTime" to "currentElapsedTime" (spelling). Thanks!

Comment 9

[jason.yang]

This is a incorrect patch. The function 'getElapsedTime' will stop sometimes when the app run on background. There is another way to resolve this PR, if the event 'moztimechange' can get last set time.

Comment 10

[Sridhar A]

(In reply to jason.yang from comment #9)
> This is a incorrect patch. The function 'getElapsedTime' will stop sometimes
> when the app run on background. There is another way to resolve this PR, if
> the event 'moztimechange' can get last set time.

Hi Jason, would you please let us know how we can get the last set time along with 'moztimechange' event.

In Gecko, nsSystemTimeChangeObserver class in TimeChangeObserver.cpp gets only a system clock change notification from HAL, which leads to firing the 'moztimechange' event. So, do we need to make a patch in Gecko & HAL to get the last set time and send it along with 'moztimechange' event.

Please let me know your opinion.

Thank you very much!

Comment 11

[Veeresh]

Hi Vance,

I request you to please check this issue.

Comment 12

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

ni LG TAM Rachelle as well

Comment 13

[Rachelle Yang [:ryang][[e-mail]]]

Hi Veeresh,

Could you please update the patch based on comment8 by Marcus for further review ?

Thank you !

Comment 14

[Veeresh]

Hi Rachelle,

As per the https://bugzilla.mozilla.org/show_bug.cgi?id=954846#c9, the patch uploaded earlier is incorrect, which even I agree. As per the suggestion in comment 9 moztimechange should get the last time set, which requires modifications in Gecko as well.

Comment 15

[BMO Automation]

Firefox OS is not being worked on