Closed
Bug 954851
Opened 10 years ago
Closed 10 years ago
JS-XMPP MUCs are duplicated after rejoining
Categories
(Chat Core :: XMPP, defect)
Chat Core
XMPP
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: florian, Assigned: florian)
Details
(Whiteboard: [1.2-blocking][regression])
Attachments
(1 file)
1.03 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1416 at 2012-05-02 09:32:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1416 as attmnt 1425 at 2012-05-02 09:32:00 UTC *** I think the cause is http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#575 that drops the reference to the existing MUC object. If I understand this code correctly, the fix is as simple as the attached patch (which I haven't tried yet).
Assignee | ||
Updated•10 years ago
|
OS: Other → All
Hardware: x86 → All
Whiteboard: [1.2-blocking][regression]
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8353177 [details] [diff] [review] Patch *** Original change on bio 1416 attmnt 1425 at 2012-05-03 22:42:12 UTC *** I tested this and it does fix the bug. When reviewing, if you are confused by that value that can be either an object or a string containing the nick, look how it's used at http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#740
Attachment #8353177 -
Attachment description: Patch (untested) → Patch
Attachment #8353177 -
Flags: review?(clokep)
Comment 3•10 years ago
|
||
Comment on attachment 8353177 [details] [diff] [review] Patch *** Original change on bio 1416 attmnt 1425 at 2012-05-03 23:19:43 UTC *** This looks fine to me. I like simple fixes like this!
Attachment #8353177 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1416 at 2012-05-03 23:26:43 UTC *** https://hg.instantbird.org/instantbird/rev/ec1dde7b6d05
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•