Closed Bug 954853 Opened 8 years ago Closed 8 years ago

No/incorrect error message when joining a channel fails

Categories

(Chat Core :: IRC, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: clokep)

References

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1418 at 2012-05-02 16:28:00 UTC ***

Both via "Join chat" and /join, the only feedback currently is the server tab error message
"There is no channel: aleth."
(note I did _not_ attempt to join a channel named aleth - the error message picks up the wrong parameter?)

For "Join chat" one would probably expect feedback in the dialog box (and the chance to try again), for /join in the conversation.
Blocks: 954050
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1418 as attmnt 1434 at 2012-05-04 00:37:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353186 - Flags: review?(bugzilla)
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment on attachment 8353186 [details] [diff] [review]
Patch

*** Original change on bio 1418 attmnt 1434 at 2012-05-04 09:18:01 UTC ***

Works very well. It would be nice if one could do without opening the tab for the nonexisting channel, but that seems almost impossible.

Thanks for fixing this!
Attachment #8353186 - Flags: review?(bugzilla) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1418 at 2012-05-04 09:28:21 UTC ***

Comment on attachment 8353186 [details] [diff] [review] (bio-attmnt 1434)
Patch

>diff --git a/chat/protocols/irc/ircBase.jsm b/chat/protocols/irc/ircBase.jsm

>-      return serverErrorMessage(this, aMessage,
>-                                _("error.noChannel", aMessage.params[0]));
>+      conversationErrorMessage(this, aMessage, "error.noChannel");
>+      return true;

Why not just:
      return conversationErrorMessage(this, aMessage, "error.noChannel");
?
Attached patch Patch v2Splinter Review
*** Original post on bio 1418 as attmnt 1436 at 2012-05-04 10:29:00 UTC ***

Florian: you're right, carrying the review forward.
Attachment #8353188 - Flags: review+
Comment on attachment 8353186 [details] [diff] [review]
Patch

*** Original change on bio 1418 attmnt 1434 at 2012-05-04 10:29:54 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353186 - Attachment is obsolete: true
*** Original post on bio 1418 at 2012-05-04 23:33:37 UTC ***

https://hg.instantbird.org/instantbird/rev/194399651469
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.