Closed Bug 954864 Opened 10 years ago Closed 10 years ago

Failure to start when there's less than 500MB of free disk space

Categories

(Chat Core :: General, defect)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: florian)

Details

(Whiteboard: [1.2-blocking][regression])

Attachments

(1 file)

*** Original post on bio 1429 by go8765 <go8765 AT gmail.com> at 2012-05-08 17:04:00 UTC ***

http://storage5.static.itmages.com/i/12/0508/h_1336496623_3253772_6e0cdec0d6.png
*** Original post on bio 1429 by go8765 <go8765 AT gmail.com> at 2012-05-08 17:06:48 UTC ***

Ubuntu 12.04
Instandbird - night buils 1.21 pre
*** Original post on bio 1429 by go8765 <go8765 AT gmail.com> at 2012-05-08 17:09:37 UTC ***

instantbird -P --no-remote     run command
than make new clear profile -- than get crush
*** Original post on bio 1429 by go8765 <go8765 AT gmail.com> at 2012-05-08 17:15:44 UTC ***

version 1.1 work normal
*** Original post on bio 1429 at 2012-05-08 23:39:51 UTC ***

The screenshot from comment 0 is the Startup failure dialog with this error message:
[Exception... "Component returned failure code: 0x8052000f (NS_ERROR_FILE_TOO_BIG) [mozIStorageConnection.setGrowthIncrement]"  nsresult: "0x8052000f (NS_ERROR_FILE_TOO_BIG)"  location: "JS frame :: jar:file:///home/go8765432/bin/instantbird_3/instantbird/omni.ja!/components/imContacts.js :: getDBConnection :: line 57"  data: no] ({})

It turns out the setGrowthIncrement method was changed to throw when there's less than 500MB of free disk space by https://bugzilla.mozilla.org/show_bug.cgi?id=666611 (Mozilla 9, so Instantbird 1.1 wasn't affected; it's a regression, as already indicated by comment 3). The C++ callers in mozilla-central don't check the return value, and the only JS caller (in a unit test) has a try/catch around it.

We should just add a try catch too.

Note: a bug for the same issue has already been filed for Thunderbird at https://bugzilla.mozilla.org/show_bug.cgi?id=740451
Status: UNCONFIRMED → ASSIGNED
Component: Other → General
Ever confirmed: true
OS: Linux → All
Product: Instantbird → Chat Core
Hardware: x86 → All
Summary: crush before start → Failure to start when there's less than 500MB of free disk space
Whiteboard: [1.2-blocking][regression]
Attached patch PatchSplinter Review
*** Original post on bio 1429 as attmnt 1457 at 2012-05-09 00:05:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353210 - Flags: review?(clokep)
Assignee: nobody → florian
Comment on attachment 8353210 [details] [diff] [review]
Patch

*** Original change on bio 1429 attmnt 1457 at 2012-05-09 00:07:05 UTC ***

Thanks for fixing this (and knowing what the issue was :)).
Attachment #8353210 - Flags: review?(clokep) → review+
*** Original post on bio 1429 at 2012-05-09 00:44:38 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/f3bf822cdbdb

Hopefully tomorrow's nightly will work for you! (As long as the nightly builds properly :)).
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.