Closed Bug 954868 Opened 10 years ago Closed 10 years ago

Switching status from OFFLINE to UNAVAILABLE actually sets status to AVAILABLE

Categories

(Chat Core :: IRC, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(2 files)

*** Original post on bio 1433 at 2012-05-16 00:07:00 UTC ***

Switching the status directly from OFFLINE to UNAVAILABLE via the UI actually sets status to AVAILABLE on the server (while the UI displays UNAVAILABLE as expected).
*** Original post on bio 1433 at 2012-05-16 16:10:21 UTC ***

After successfully logging in, we should check our status and send AWAY if we're unavailable (i.e. we won't receive a status change telling us to switch to away).
Attached patch PatchSplinter Review
*** Original post on bio 1433 as attmnt 1480 at 2012-05-16 20:32:00 UTC ***

Also fixes a hitherto unnoticed bug that if the user was away, but changed the away message, that was not reported to the server.
Attachment #8353233 - Flags: review?(clokep)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
*** Original post on bio 1433 as attmnt 1486 at 2012-05-19 15:29:00 UTC ***

This looks good, I'm attaching a patch with the paths fixed and I changed the LOG statement right above this to a DEBUG statement.
Attachment #8353239 - Flags: review?(bugzilla)
Comment on attachment 8353233 [details] [diff] [review]
Patch

*** Original change on bio 1433 attmnt 1480 at 2012-05-19 15:29:46 UTC ***

Looks good, please make sure I didn't change anything of importance in attachment 8353239 [details] [diff] [review] (bio-attmnt 1486). :)
Attachment #8353233 - Flags: review?(clokep) → review+
Comment on attachment 8353239 [details] [diff] [review]
Patch with fixed paths and change to log statement

*** Original change on bio 1433 attmnt 1486 at 2012-05-19 15:33:38 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353239 - Flags: review?(bugzilla) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1433 at 2012-05-20 17:58:59 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/33cc73c688a3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
Whiteboard: [checkin-needed]
You need to log in before you can comment on or make changes to this bug.