Closed Bug 954870 Opened 8 years ago Closed 8 years ago

Summary page empty due to Top Protocols page modifications

Categories

(Instantbird :: Account wizard, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wnayes, Assigned: florian)

References

Details

(Whiteboard: [regression])

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 1436 at 2012-05-16 18:42:00 UTC ***

The summary page is blank after configuring an account in the wizard. The error console displays that protoLabel is null, which it uses to populate the summary. This error was introduced by bug 954826 (bio 1391) removing the protoLabel from accountWizard.xul.
*** Original post on bio 1436 as attmnt 1478 at 2012-05-16 19:00:00 UTC ***

This restores the protoLabel which is referenced when the summary page is shown. The localized string is also replaced.
Attachment #8353231 - Flags: review?(clokep)
Blocks: 954826
*** Original post on bio 1436 at 2012-05-16 19:05:41 UTC ***

Hmm...would it make more sense to change the code around [1] to reference the proper element instead of depending on this hidden label's value?

(I.e. getting the protocol list itself from protolist and seeing what is selected on it. Taking into account that it could be protolist of topprotolist.)

[1] http://lxr.instantbird.org/instantbird/source/instantbird/content/accountWizard.js#377
Assignee: nobody → wnayes
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
*** Original post on bio 1436 at 2012-05-16 19:25:17 UTC ***

After talking to wnayes on IRC, I'm fairly certain that this patch makes sense, but I'm hesitant to r+ it without trying it (and not knowing this code very well).
*** Original post on bio 1436 as attmnt 1479 at 2012-05-16 19:36:00 UTC ***

This patch has the summary pull the "Protocol:" string from the accountWizard.properties file, removing the need for the hidden label.
*** Original post on bio 1436 as attmnt 1481 at 2012-05-16 22:10:00 UTC ***

I like neither of the 2 proposed patches. I'm proposing a third solution: putting the protocol string next to the one used for the username. Will, would you like to look at that patch?
Attachment #8353234 - Flags: review?
Comment on attachment 8353231 [details] [diff] [review]
Restore the label and localization used for the summary

*** Original change on bio 1436 attmnt 1478 at 2012-05-16 22:10:10 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353231 - Attachment is obsolete: true
Attachment #8353231 - Flags: review?(clokep)
Comment on attachment 8353232 [details] [diff] [review]
Alternative patch replacing the label with a localized property

*** Original change on bio 1436 attmnt 1479 at 2012-05-16 22:10:10 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353232 - Attachment is obsolete: true
Comment on attachment 8353234 [details] [diff] [review]
Another alternative patch

*** Original change on bio 1436 attmnt 1481 at 2012-05-16 22:24:20 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353234 - Flags: review? → review+
*** Original post on bio 1436 at 2012-05-16 22:27:16 UTC ***

https://hg.instantbird.org/instantbird/rev/ac5bbbf0dddd
Assignee: wnayes → florian
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [regression]
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.