Closed
Bug 954893
Opened 10 years ago
Closed 10 years ago
Do not send blank lines / empty messages
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: aleth, Assigned: aleth)
References
Details
Attachments
(1 file)
857 bytes,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1460 at 2012-05-22 23:26:00 UTC *** Ending a message with Ctrl-Return Return produces a ERR_NOTEXTTOSEND message. We should not be sending those blank lines.
Comment 1•10 years ago
|
||
*** Original post on bio 1460 at 2012-05-22 23:32:33 UTC *** So I think all you have to do is check in the send message whether the message has any length [1]. The same method will not be changed for both ircChannel and ircConversation. [1] http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#119
Updated•10 years ago
|
Summary: Check whether messages to be sent end with blank lines → Do not send blank lines / empty messages
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1460 as attmnt 1607 at 2012-06-14 21:35:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353364 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
Comment on attachment 8353364 [details] [diff] [review] Patch *** Original change on bio 1460 attmnt 1607 at 2012-06-15 01:12:39 UTC *** Couldn't have done it better myself. ;)
Attachment #8353364 -
Flags: review?(clokep) → review+
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 5•10 years ago
|
||
*** Original post on bio 1460 at 2012-06-21 00:28:17 UTC *** Checked in as http://hg.instantbird.org/instantbird/rev/9baa0795be9a Thanks for fixing this annoyance.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•