Closed Bug 954896 Opened 10 years ago Closed 10 years ago

[Tab complete] List possible completions only on second tab press when pinged

Categories

(Instantbird Graveyard :: Conversation, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(1 file, 3 obsolete files)

*** Original post on bio 1463 at 2012-05-24 00:32:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1463 as attmnt 1520 at 2012-05-24 00:32:00 UTC ***

Something to try out ;)

Advantage: No long list of possible completions shows up when we are just replying to a ping. (NB this is currently the only case where a completion is auto-filled immediately when it is not unique).

Disadvantage: No immediate visual indication there are alternative completions available.

Only OK if one can assume the user is so familiar with pressing <tab> multiple times that she does it without thinking anyway when expecting a different nick.
Attachment #8353272 - Flags: feedback?
*** Original post on bio 1463 at 2012-05-24 01:02:26 UTC ***

The code looks OK when glancing at it...but you definitely need more comments in there. :(
*** Original post on bio 1463 at 2012-05-24 01:06:10 UTC ***

It's not really about the code atm, but whether this is a good idea, overall.
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1463 as attmnt 1521 at 2012-05-24 01:51:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353273 - Flags: feedback?
Comment on attachment 8353272 [details] [diff] [review]
Patch

*** Original change on bio 1463 attmnt 1520 at 2012-05-24 01:51:34 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353272 - Attachment is obsolete: true
Attachment #8353272 - Flags: feedback?
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8353273 [details] [diff] [review]
Patch

*** Original change on bio 1463 attmnt 1521 at 2012-05-24 09:29:46 UTC ***

(In reply to comment #0)

> Advantage: No long list of possible completions shows up when we are just
> replying to a ping. (NB this is currently the only case where a completion is
> auto-filled immediately when it is not unique).

Replying to a ping isn't really the only case. There's also the case of only one active nick in the list of completions. And I think this change is desired in that case too :).

I look forward to trying this in nightlies to confirm if it's OK or turns out to be annoying! Thanks for working on this! :-)

feedback+ would be r+ if you had requested review, but I think you need some more comments to please Patrick ;).
Attachment #8353273 - Flags: feedback? → feedback+
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1463 as attmnt 1532 at 2012-05-27 21:04:00 UTC ***

Add comment.

(In reply to comment #4)
> > Advantage: No long list of possible completions shows up when we are just
> > replying to a ping. (NB this is currently the only case where a completion is
> > auto-filled immediately when it is not unique).
> 
> Replying to a ping isn't really the only case. There's also the case of only
> one active nick in the list of completions. And I think this change is desired
> in that case too :).

The code actually doesn't care what's causing a preferred nick, but at the moment pings are the only case (for a list of length one, we don't show the list of completions anyway).
Attachment #8353286 - Flags: review?(florian)
Comment on attachment 8353273 [details] [diff] [review]
Patch

*** Original change on bio 1463 attmnt 1521 at 2012-05-27 21:04:16 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353273 - Attachment is obsolete: true
Attached patch PatchSplinter Review
*** Original post on bio 1463 as attmnt 1533 at 2012-05-27 21:07:00 UTC ***

Even better comment.
Attachment #8353287 - Flags: review?(florian)
Comment on attachment 8353286 [details] [diff] [review]
Patch

*** Original change on bio 1463 attmnt 1532 at 2012-05-27 21:07:42 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353286 - Attachment is obsolete: true
Attachment #8353286 - Flags: review?(florian)
Comment on attachment 8353287 [details] [diff] [review]
Patch

*** Original change on bio 1463 attmnt 1533 at 2012-05-27 21:26:46 UTC ***

I look forward to using a nightly including this patch, thanks!

(In reply to comment #5)
> (In reply to comment #4)
> > Replying to a ping isn't really the only case. There's also the case of only
> > one active nick in the list of completions. And I think this change is desired
> > in that case too :).
> 
> The code actually doesn't care what's causing a preferred nick, but at the
> moment pings are the only case (for a list of length one, we don't show the
> list of completions anyway).

For future reference to avoid confusion if anybody reads these comments again, we just discussed this on IRC and having only one active nick in a list of several possible completions is really another case triggering this bug.
Attachment #8353287 - Flags: review?(florian) → review+
*** Original post on bio 1463 at 2012-05-28 13:09:01 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/5f8b04383d01
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.