Closed Bug 954908 Opened 10 years ago Closed 10 years ago

"Connect this account now."-label for checkbox misleading

Categories

(Instantbird Graveyard :: Account wizard, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benediktp, Assigned: FeuerFliege)

Details

(Whiteboard: [1.3-wanted])

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1475 at 2012-06-01 09:27:00 UTC ***

The "Connect this account now."-label for the checkbox on the last page of the account wizard might be a bit misleading since it doesn't imply that this will connect the account at every start again.

Maybe "Connect this account automatically." might be better?
Attached patch patch v1 (obsolete) — Splinter Review
*** Original post on bio 1475 as attmnt 1544 at 2012-06-01 11:36:00 UTC ***

Is this just about changing the label or should there are two options ("Connect now" and "Connect automatically")?

If it's the former it should be as easy in the attached patch.
Comment on attachment 8353299 [details] [diff] [review]
patch v1

*** Original change on bio 1475 attmnt 1544 at 2012-06-01 12:04:25 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353299 - Flags: review?(florian)
Comment on attachment 8353299 [details] [diff] [review]
patch v1

*** Original change on bio 1475 attmnt 1544 at 2012-06-01 12:12:12 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353299 - Flags: review?(florian) → review?(benediktp)
Comment on attachment 8353299 [details] [diff] [review]
patch v1

*** Original change on bio 1475 attmnt 1544 at 2012-06-01 12:37:29 UTC ***

I noticed the other day that this is strange too. I like this change and think we should take it. Thanks for changing this.
Attachment #8353299 - Flags: review?(benediktp) → review+
Assignee: nobody → bug
Status: NEW → ASSIGNED
Whiteboard: [checkin-needed]
Comment on attachment 8353299 [details] [diff] [review]
patch v1

*** Original change on bio 1475 attmnt 1544 at 2012-06-01 12:40:32 UTC ***

So I r+ed this without really looking at all the changes. :-D

>diff -r 3f9722c19f85 instantbird/content/accountWizard.xul
>--- a/instantbird/content/accountWizard.xul	Thu May 31 13:14:34 2012 +0200
>+++ b/instantbird/content/accountWizard.xul	Fri Jun 01 13:25:03 2012 +0200
>@@ -137,7 +137,7 @@
>       <rows id="summaryRows"/>
>     </grid>
>     <separator/>
>-    <checkbox id="connectNow" label= "&accountSummary.connectNow.label;" checked="true"/>
>+    <checkbox id="connectNow" label="&accountSummary.connectNow2.label;" checked="true"/>
We should probably change this ID at the same time to connectAutomatically

>   </wizardpage>
> 
> </wizard>
>diff -r 3f9722c19f85 instantbird/locales/en-US/chrome/instantbird/accountWizard.dtd
>--- a/instantbird/locales/en-US/chrome/instantbird/accountWizard.dtd	Thu May 31 13:14:34 2012 +0200
>+++ b/instantbird/locales/en-US/chrome/instantbird/accountWizard.dtd	Fri Jun 01 13:25:03 2012 +0200
>@@ -33,4 +33,4 @@
> 
> <!ENTITY accountSummaryTitle.label   "Summary">
> <!ENTITY accountSummaryInfo.label    "A summary of the information you entered is displayed below. Please check it before the account is created.">
>-<!ENTITY accountSummary.connectNow.label "Connect this account now.">
>+<!ENTITY accountSummary.connectNow2.label "Connect this account automatically.">
Instead of changing this by adding a "2", we can make it make more sense by changing it to accountSummary.connectAutomatically.label.
Attachment #8353299 - Flags: review+ → review-
Whiteboard: [checkin-needed]
*** Original post on bio 1475 at 2012-07-01 12:53:09 UTC ***

As we are string frozen, it is too late to fix this for 1.2, but it really is misleading: I often create new accounts for testing on my dev profile and leave the flag so they immediately connect. I am then annoyed on restart as they connect automatically... this happens despite knowing what the flag is for.
Whiteboard: [1.3-wanted]
*** Original post on bio 1475 at 2012-10-17 18:31:48 UTC ***

Florian, are you going to update the patch for 1.3? If you're busy, I can take over if you like.
Attached patch patch v2Splinter Review
*** Original post on bio 1475 as attmnt 1980 at 2012-10-18 07:51:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353739 - Flags: review?(clokep)
Comment on attachment 8353299 [details] [diff] [review]
patch v1

*** Original change on bio 1475 attmnt 1544 at 2012-10-18 07:51:37 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353299 - Attachment is obsolete: true
Comment on attachment 8353739 [details] [diff] [review]
patch v2

*** Original change on bio 1475 attmnt 1980 at 2012-10-18 10:23:51 UTC ***

This looks good, thanks! :)
Attachment #8353739 - Flags: review?(clokep) → review+
Whiteboard: [1.3-wanted] → [1.3-wanted][checkin-needed]
*** Original post on bio 1475 at 2012-10-25 12:07:39 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/52437093e47b

Thanks for fixing this!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.3-wanted][checkin-needed] → [1.3-wanted]
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.