954911 - IRC /topic help text is incorrect.

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 1478 at 2012-06-01 23:34:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch v1

*** Original post on bio 1478 as attmnt 1548 at 2012-06-01 23:34:00 UTC ***

The topic help text currently says you can view or change a topic...it should say change or remove a topic.

Comment 2

[aleth [:aleth]]

Comment on attachment 8353303 [details] [diff] [review]
Patch v1

*** Original change on bio 1478 attmnt 1548 at 2012-06-01 23:40:17 UTC ***

I don't think it's obvious from that how to clear the topic. How about something like "Change the channel topic, or remove the current topic by not specifying a new topic." (not an ideal string either yet)

Comment 3

[Patrick Cloke [:clokep]]

*** Original post on bio 1478 at 2012-06-02 17:24:20 UTC ***

(In reply to comment #1)
> Comment on attachment 8353303 [details] [diff] [review] (bio-attmnt 1548) [details]
> Patch v1
> 
> I don't think it's obvious from that how to clear the topic. How about
> something like "Change the channel topic, or remove the current topic by not
> specifying a new topic." (not an ideal string either yet)

Yeah, I can agree with that...the whole help topic text in general is rather cryptic.

Would something this be better?
> topic [<new topic>]: Change the channel topic (do not proview a <new topic> to
> clear the topic).

If so, I'll make up the patch. :)

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Patch v2

*** Original post on bio 1478 as attmnt 1559 at 2012-06-04 23:46:00 UTC ***

After some discussion on IRC...

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8353303 [details] [diff] [review]
Patch v1

*** Original change on bio 1478 attmnt 1548 at 2012-06-04 23:46:38 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8353314 [details] [diff] [review]
Patch v2

*** Original change on bio 1478 attmnt 1559 at 2012-06-04 23:49:41 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 7

[Patrick Cloke [:clokep]]

*** Original post on bio 1478 at 2012-06-04 23:51:04 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/afdca7970880