Closed
Bug 954912
Opened 10 years ago
Closed 10 years ago
[Tab complete] Remove trailing ": " suffix when pressing backspace before undoing completion
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file, 4 obsolete files)
2.39 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1479 at 2012-06-02 13:27:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1479 as attmnt 1549 at 2012-06-02 13:27:00 UTC *** Current behaviour (at the beginning of a message): c<tab> completes to "clokep: " Press <Backspace> and we are back at "c". Proposed behaviour: c<tab> completes to "clokep: " Press <Backspace> and we get "clokep". Press <Backspace> again and we are back at "c".
Attachment #8353304 -
Flags: review?(florian)
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1479 as attmnt 1550 at 2012-06-02 13:59:00 UTC *** Remove duplicated return statement.
Attachment #8353305 -
Flags: review?(florian)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8353304 [details] [diff] [review] Patch *** Original change on bio 1479 attmnt 1549 at 2012-06-02 13:59:57 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353304 -
Attachment is obsolete: true
Attachment #8353304 -
Flags: review?(florian)
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1479 as attmnt 1551 at 2012-06-02 14:48:00 UTC *** This is better, I think. (Also doesn't add a trailing space if we remove the comma separation, for consistency with the behaviour when completing nicks within messages.)
Attachment #8353306 -
Flags: review?(florian)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8353305 [details] [diff] [review] Patch *** Original change on bio 1479 attmnt 1550 at 2012-06-02 14:48:17 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353305 -
Attachment is obsolete: true
Attachment #8353305 -
Flags: review?(florian)
Assignee | ||
Comment 6•10 years ago
|
||
*** Original post on bio 1479 as attmnt 1552 at 2012-06-02 14:50:00 UTC *** Remove duplicate let.
Attachment #8353307 -
Flags: review?(florian)
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8353306 [details] [diff] [review] Patch *** Original change on bio 1479 attmnt 1551 at 2012-06-02 14:50:45 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353306 -
Attachment is obsolete: true
Attachment #8353306 -
Flags: review?(florian)
Assignee | ||
Comment 8•10 years ago
|
||
*** Original post on bio 1479 as attmnt 1553 at 2012-06-02 15:21:00 UTC *** pop() reduces array length by one ;)
Attachment #8353308 -
Flags: review?(florian)
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8353307 [details] [diff] [review] Patch *** Original change on bio 1479 attmnt 1552 at 2012-06-02 15:21:26 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353307 -
Attachment is obsolete: true
Attachment #8353307 -
Flags: review?(florian)
Comment 10•10 years ago
|
||
Comment on attachment 8353308 [details] [diff] [review] Patch *** Original change on bio 1479 attmnt 1553 at 2012-06-02 17:18:39 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353308 -
Flags: review?(florian) → review+
Comment 11•10 years ago
|
||
*** Original post on bio 1479 at 2012-06-03 04:58:13 UTC *** Committed as http://hg.instantbird.org/instantbird/rev/8b8724360bf6 Thanks!
Assignee: nobody → aleth
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•