Closed
Bug 954914
Opened 10 years ago
Closed 10 years ago
Style visible tabs in all-tabs menu like Firefox does
Categories
(Instantbird Graveyard :: Conversation, enhancement)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: benediktp, Assigned: benediktp)
Details
Attachments
(2 files)
11.71 KB,
image/png
|
Details | |
2.26 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1481 at 2012-06-04 10:16:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1481 as attmnt 1558 at 2012-06-04 10:16:00 UTC *** Firefox is styling tabs which are currently visible in the tabstrip differently in the all-tabs menu. We chould port that to keep IB as familiar as possible for people knowing Fx already. I'm attaching screenshot of Fx-all-tabs menu; the currently visible section has a dark gray background.
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1481 at 2013-05-30 18:31:14 UTC *** This is only a matter of adding the correct style to the css file. The rule for this is .alltabs-item[tabIsVisible]. Firefox is using the following for Windows at the moment: .alltabs-item[tabIsVisible] { /* box-shadow instead of background-color to work around native styling */ box-shadow: inset -5px 0 ThreeDShadow !important; }
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1481 at 2013-05-30 18:32:38 UTC *** Sorry, the "!important" there comes from my userChrome.css testing. It's not there in the original style.
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1481 as attmnt 2468 at 2013-05-30 21:41:00 UTC *** The patch adds the rule and styling as Firefox currently has it [1]. It's the same on all supported OS'. Tested only on Windows. [1] http://mxr.mozilla.org/mozilla-central/search?string=tabIsVisible
Attachment #8354235 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → benediktp
Status: NEW → ASSIGNED
Comment 5•10 years ago
|
||
Comment on attachment 8354235 [details] [diff] [review] Patch *** Original change on bio 1481 attmnt 2468 at 2013-05-30 22:15:49 UTC *** Stealing the review as this looks simple enough that I'm confident the patch is OK without testing it.
Attachment #8354235 -
Flags: review?(clokep) → review+
Comment 6•10 years ago
|
||
*** Original post on bio 1481 at 2013-05-31 00:39:13 UTC *** Thanks Mic! http://hg.instantbird.org/instantbird/rev/2235e9d8d387
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•