Closed
Bug 954931
Opened 10 years ago
Closed 10 years ago
"this.buddy is undefined" on merging two IRC buddies
Categories
(Instantbird Graveyard :: Contacts window, defect)
Instantbird Graveyard
Contacts window
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file, 1 obsolete file)
1019 bytes,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1498 at 2012-06-08 20:35:00 UTC *** Using drag and drop. The buddies had different names, but were on the same account. Timestamp: 06/08/2012 11:13:45 AM Error: this.buddy is undefined Source File: chrome://instantbird/content/buddy.xml Line: 222
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1498 at 2012-06-12 15:53:27 UTC *** Reproduced this again. STR is simply dragging an existing buddy onto an expanded (non-merged) buddy.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1498 as attmnt 1608 at 2012-06-14 21:58:00 UTC *** Happens only when dropping the buddy onto the drop target, in which case the correct thing to do is to return and let the event be handled by the contact.
Attachment #8353365 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
Comment on attachment 8353365 [details] [diff] [review] Patch *** Original change on bio 1498 attmnt 1608 at 2012-06-14 22:40:22 UTC *** I think I should double check this.
Attachment #8353365 -
Flags: review?(florian)
Comment 4•10 years ago
|
||
Comment on attachment 8353365 [details] [diff] [review] Patch *** Original change on bio 1498 attmnt 1608 at 2012-06-15 21:42:35 UTC *** This looks OK to me, I do wonder if we should have a comment saying when that condition occurs?
Attachment #8353365 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 1498 as attmnt 3101 at 2013-11-29 14:43:00 UTC *** Same diagnosis, better patch.
Attachment #8354884 -
Flags: review?(florian)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8353365 [details] [diff] [review] Patch *** Original change on bio 1498 attmnt 1608 at 2013-11-29 14:43:05 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353365 -
Attachment is obsolete: true
Attachment #8353365 -
Flags: review?(florian)
Comment 7•10 years ago
|
||
Comment on attachment 8354884 [details] [diff] [review] Patch2 *** Original change on bio 1498 attmnt 3101 at 2013-12-01 17:10:35 UTC *** I'm way more confident taking this version of the patch, thanks for looking into it again! I haven't tested it locally and I think I would like to test it in a nightly before we release with it; but I don't see how this could go wrong, and I assume you have tested it locally yourself :).
Attachment #8354884 -
Flags: review?(florian) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 8•10 years ago
|
||
*** Original post on bio 1498 at 2013-12-01 23:32:53 UTC *** http://hg.instantbird.org/instantbird/rev/1752ef472615
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•