954965 - Sending messages in a parted channel should fail better

Status: RESOLVED INVALID

(Chat Core :: IRC, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1533 at 2012-06-21 01:04:00 UTC ***

Current behaviour: The message is sent and we get a misleading "There is no channel" message back.

Options:
- Fix this at the UI level for all protocols (check the chat hasn't been left in conversation.xml)
- Fix this at the IRC level (via a system message I suppose).

Comment 1

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1533 as attmnt 1654 at 2012-06-21 01:14:00 UTC ***

Fixed in the UI because 
03:06:01 AM   clokep: Bah...so the tricky thing about that bug you just filed.
03:06:01 AM - clokep: You can technically send message sto an IRC channel you're not in.
03:06:55 AM - aleth: But we can fix the bug for sending to the channel whose tab we are typing from
03:07:09 AM - aleth: (Which suggests it should be fixed in the UI)
03:09:40 AM - clokep: Yup. :)

Comment 2

[aleth [:aleth]]

*** Original post on bio 1533 at 2012-06-21 09:33:03 UTC ***

Maybe it should also write a system message ("Rejoin the chat to send messages")?

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8353411 [details] [diff] [review]
Patch

*** Original change on bio 1533 attmnt 1654 at 2012-06-25 12:30:43 UTC ***

So you can technically send to a channel you're no longer in when using IRC. I think the rest of our code supports this, this wouldn't allow that to happen anymore. (Sure you wouldn't receive any responses, but still...)

Comment 4

[aleth [:aleth]]

*** Original post on bio 1533 at 2012-06-25 12:41:53 UTC ***

Nothing to fix here then if sending to a parted channel is possible on some servers.

Comment 5

[aleth [:aleth]]

*** Original change on bio 1533 at 2012-06-25 12:42:20 UTC was without comment, so any subsequent comment numbers will be shifted ***