Closed Bug 954975 Opened 10 years ago Closed 5 years ago

Automate creation of prpl.manifest

Categories

(Chat Core :: General, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: clokep, Unassigned)

Details

*** Original post on bio 1543 at 2012-06-23 23:57:00 UTC ***

http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/prpl.manifest#1

7:50:06 PM - flo: clokep: "Ah, and that's not built off of STATIC_PRPLS?" unfortunately, it's the prpl ids, not the directory names
7:50:14 PM - flo: so you need a line for aim and one for icq, not an oscar line
7:50:45 PM - flo: but we should find a way to generate it automatically
7:50:49 PM - flo: it's not trivial though :-/
7:52:10 PM - flo: I think I see how we can automate it
7:52:23 PM - flo: but it will require some makefile hacking that's IMHO out of the scope for that [bug 954378 (bio 944)]
7:52:29 PM - clokep: I agree.

Also, should that be in purple/libpurple? flo kind of suggested that.
*** Original post on bio 1543 at 2012-06-24 00:06:47 UTC ***

The solution I have in mind is that prpl.mk should add a PRPL_ID variable initialized to $(PROTOCOL) so that the Makefiles of prpls for which the prpl id matches the directory name don't need any change. Protocol directories that need a special handling of prpl ids can then set that variable, for example oscar/Makefile.in would do:
PRPL_ID=aim icq

When compiling a prpl in the form of a static library, the Makefile (with a libs:: rule in prpl-rules.mk) should generate a prpl.manifest or $(PROTOCOL).manifest file.

libpurple/Makefile.in need to merge all the manifest files of the prpls it's going to link statically, and to install the prpl.manifest file in the components folder if at least one prpl is statically linked.
purplexpcom is no longer being developed.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.