Closed Bug 954978 Opened 10 years ago Closed 10 years ago

license.html not distributed with Instantbird

Categories

(Instantbird Graveyard :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: florian)

References

Details

(Whiteboard: [1.2-blocking])

Attachments

(2 files, 2 obsolete files)

*** Original post on bio 1546 at 2012-06-24 03:55:00 UTC ***

So if you go to the About dialog, then credits. At the bottom there is a link for "license". Clicking this brought up a page saying it doesn't exist for me. I think the file is supposed to be [1], but no license.html exists for me. Additionally, there is LICENSE.txt [2] which still states we distribute as MPL 1.1 tri-license.

Additionally, we need to include the Apple license once bug 954378 (bio 944) is checked in.

[1] http://lxr.instantbird.org/instantbird/source/instantbird/app/app-license.html
[2] http://lxr.instantbird.org/instantbird/source/instantbird/LICENSE.txt
Whiteboard: [1.2-blocking]
Blocks: 954378
Attached patch WIP v1 (obsolete) — Splinter Review
*** Original post on bio 1546 as attmnt 1746 at 2012-07-19 01:36:00 UTC ***

This adds the Apple SDK license to about:license and switches the about dialog to open about:license. I can't seem to get the app-license.html file to work, however, which is supposed to add "Official binaries of this product released by the Instantbird team are made available under the GNU General Public License (GPL) version 2.0 or later." to about:license.
Comment on attachment 8353506 [details] [diff] [review]
WIP v1

*** Original change on bio 1546 attmnt 1746 at 2012-07-19 10:50:23 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353506 - Flags: feedback?(florian)
*** Original post on bio 1546 at 2012-07-19 12:44:53 UTC ***

I thought we would be patching license.html from instantbird/app/Makefile.in rather than when doing the checkout, but I guess putting it with the other patches is simplier (it's a patch we will never be able to upstream though).
*** Original post on bio 1546 as attmnt 1768 at 2012-08-01 22:36:00 UTC ***

Attachment 8353506 [details] [diff] (bio-attmnt 1746) doesn't work.
We need to port http://hg.mozilla.org/comm-central/rev/f810828f8ca1 + some random fixes.
We discussed this on IRC and agreed that I'm taking care of the build system changes while clokep updates the license.html and LICENSE.txt files.
Attachment #8353529 - Flags: review?(clokep)
Comment on attachment 8353506 [details] [diff] [review]
WIP v1

*** Original change on bio 1546 attmnt 1746 at 2012-08-01 22:36:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353506 - Attachment is obsolete: true
Attachment #8353506 - Flags: feedback?(florian)
*** Original post on bio 1546 as attmnt 1769 at 2012-08-01 22:55:00 UTC ***

This is the license.html update (and LICENSE.txt) mostly untested since I can't get flo's changes to build...
Attachment #8353530 - Flags: review?(florian)
*** Original post on bio 1546 as attmnt 1770 at 2012-08-01 23:19:00 UTC ***

This:
 - Fixes the wording of LICENSE.txt
 - Switches the Makefile.in around to build with pymake.
 - Gets rid of the href="" which causes a "What program would you like to open this in" dialog to show up for me.
 - Removes dead code from credits.xhtml.
Attachment #8353531 - Flags: review?(florian)
Comment on attachment 8353530 [details] [diff] [review]
Patch (license.html and LICENSE.txt part)

*** Original change on bio 1546 attmnt 1769 at 2012-08-01 23:19:36 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353530 - Attachment is obsolete: true
Attachment #8353530 - Flags: review?(florian)
Comment on attachment 8353531 [details] [diff] [review]
Patch (license.html and LICENSE.txt part) v2

*** Original change on bio 1546 attmnt 1770 at 2012-08-01 23:38:47 UTC ***

Ok, thanks. I would just like to rename license.patch to bonjour-and-GPL-licenses.patch so that I don't have to open the file over and over again to know what it's about.
Attachment #8353531 - Flags: review?(florian) → review+
Comment on attachment 8353529 [details] [diff] [review]
Patch (build system part)

*** Original change on bio 1546 attmnt 1768 at 2012-08-01 23:42:30 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353529 - Flags: review?(clokep) → review+
*** Original post on bio 1546 at 2012-08-02 00:39:39 UTC ***

Both patches checked in as http://hg.instantbird.org/instantbird/rev/3402ce2191b3
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.