Closed Bug 954999 Opened 10 years ago Closed 10 years ago

JS-XMPP doesn't handle message type="error" stanza, and instead displays the messages again in the conversation as incoming

Categories

(Chat Core :: XMPP, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: florian)

References

Details

(Whiteboard: [1.2-blocking])

Attachments

(1 file)

*** Original post on bio 1568 at 2012-07-02 23:28:00 UTC ***

Symptom: When sending a message, it bounces.

Moved from original bug report in bug 954836 (bio 1401):
Donnie Muurdock 2012-07-03 01:13:07 CEST
i kinda have same problem this guy is having but im having problem when i now
the user is signed off but it still show he one line if i send him a message it
will just relay back to to me like he repting everything i type like this 

7:07:40 PM - DGMurdockIII: p
7:07:40 PM - Björn Holine: p

it dosent happed that ofter but i now it a bug
because the offline messaging dosent work for google talk on instant at least with my friend using pidgin so i thnk there could be some coloration to that
*** Original post on bio 1568 at 2012-07-02 23:40:22 UTC ***

01:37:54 AM - DGMurdockIII: im not sure if it has to do with the offline messaging but i now it dose not work i tryed to send him some stuff on instantbird he has never recived it
01:38:03 AM - DGMurdockIII: ok
01:38:15 AM - aleth: I don't know if gtalk supports offline messaging.
01:38:22 AM - DGMurdockIII: itit dose
01:39:00 AM - DGMurdockIII: http://googletalk.blogspot.com/2006/11/offline-messages.html
*** Original post on bio 1568 at 2012-07-03 19:30:42 UTC ***

09:24:16 PM - DGMurdockIII: ok i just my friend that this happend with on gtalk as this only person i talk with on gtalk well one other person but not only once in a while this guy every day and he dose not have Save chat history on he has Never save chat history. 
09:24:35 PM - aleth: So he can't get offline messages
*** Original post on bio 1568 at 2012-07-11 14:10:58 UTC ***

Given the conversation quoted above (comment 2), it's not a bug that the user couldn't receive offline messages, so the real bug here is the very poor (or rather, completely unhandled) error reporting.
Summary: Gtalk buddies sometimes appear online when they are actually offline → JS-XMPP doesn't handle message type="error" stanza, and instead displays the messages again in the conversation as incoming
Whiteboard: [1.3-wanted]
*** Original post on bio 1568 by Donnie Muurdock <dgmurdockiii AT gmail.com> at 2012-07-12 19:12:03 UTC ***

i dont think bug has to do with offline messaging but but im not sure why it happens but maybe not detecting that other user has disconnected
*** Original post on bio 1568 at 2012-07-26 10:13:01 UTC ***

1.2-blocking for a workaround. 1.3-wanted for a real fix.

For 1.2 I wonder if we should just drop the error message, or reuse a not really related existing error message from xmpp.properties.
Possible existing messages:
connection.error.receivedUnexpectedData=Received unexpected data
connection.error.incorrectResponse=Received an incorrect response
Whiteboard: [1.3-wanted] → [1.2-blocking][1.3-wanted]
Attached patch PatchSplinter Review
*** Original post on bio 1568 as attmnt 1762 at 2012-07-27 17:02:00 UTC ***

- I'm not satisfied of the code duplication between the 2 incomingMessage methods, but I don't see a good solution, and it's just 4 lines...
- I haven't tested this at all, as I don't see right now a way to cause messages to fail to be delivered.
Attachment #8353523 - Flags: review?
Assignee: nobody → florian
Comment on attachment 8353523 [details] [diff] [review]
Patch

*** Original change on bio 1568 attmnt 1762 at 2012-07-27 17:07:31 UTC ***

This looks fine (to my understanding of XMPP).

(In reply to comment #6)
> - I'm not satisfied of the code duplication between the 2 incomingMessage
> methods, but I don't see a good solution, and it's just 4 lines...
That was fixed (kind of) by bug 954793 (bio 1359) for IRC.

> - I haven't tested this at all, as I don't see right now a way to cause
> messages to fail to be delivered.
You need GTalk to go down again? :-D
Attachment #8353523 - Flags: review? → review+
*** Original post on bio 1568 at 2012-07-27 17:11:01 UTC ***

(In reply to comment #7)

> > - I haven't tested this at all, as I don't see right now a way to cause
> > messages to fail to be delivered.
> You need GTalk to go down again? :-D

Kind of. I'll try to find some way to craft invalid messages so that the server replies to me with an error. Need to read more of the XMPP spec to see how a message can be invalid :).
*** Original post on bio 1568 at 2012-07-31 10:18:20 UTC ***

I tested this by following the indication in https://support.google.com/talk/answer/47238/
Gtalk replies with an error when talking to an offline contact that has disabled chat log storage:
 <error xmlns="jabber:client" code="503" type="cancel">
  <service-unavailable xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
 </error>

The patch worked correctly during my test, this system message was displayed in the conversation:
12:15:39 - Received an incorrect response
*** Original post on bio 1568 at 2012-07-31 10:46:55 UTC ***

https://hg.instantbird.org/instantbird/rev/10df3f6d79e2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.2-blocking][1.3-wanted] → [1.2-blocking]
Target Milestone: --- → 1.2
Depends on: 955040
You need to log in before you can comment on or make changes to this bug.