Closed Bug 955003 Opened 10 years ago Closed 10 years ago

Contacts added directly to "Other Contacts" don't show until collapsed/expanded

Categories

(Instantbird Graveyard :: Contacts window, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: aleth)

Details

(Whiteboard: [1.5-wanted])

Attachments

(1 file)

*** Original post on bio 1572 by Aqeel Zafar <aqeel AT aqeeliz.com> at 2012-07-04 14:14:00 UTC ***

I have only tried it using GTalk protocol.

Any new contact added doesn't show up in contact list, not even after restarting Instantbird. The only way around I have found is to close Instantbird and delete the cache from profile directory.

This happens both when I initiate an add request, or if I receive one from someone.
*** Original post on bio 1572 by Aqeel Zafar <aqeel AT aqeeliz.com> at 2012-07-04 14:16:31 UTC ***

Forgot to mention my Instantbird version, I am using the latest nightly.
Component: General → XMPP
OS: Windows 7 → All
Hardware: x86 → All
Summary: New contacts added doesn't show up in Contact list → New Gtalk contacts added doesn't show up in Contact list
*** Original post on bio 1572 at 2012-07-04 14:20:19 UTC ***

When you turn on "Show offline buddies" in the contact list context menu, do you see the added contacts? (i.e. are they not added correctly, or is it their status which is not received properly?)
*** Original post on bio 1572 by Aqeel Zafar <aqeel AT aqeeliz.com> at 2012-07-04 14:47:47 UTC ***

Unfortunately, it isn't very easy to test this many times.

I added another account, and it didn't show up in my list, I checked 'Show offline buddies' and made some tags visible to find that buddy and accidentally changed tags/groups of one contact while doing so and it showed up in my list.

I asked someone else to add me, accepted their request and did all of the things I had done in previous step, but they still haven't shown up in my list yet (not even offline).

As for my previous attempt at adding new contact (mentioned in description), that contact was already in my list using G+ (encrypted G+ id), in GTalk when you add those people with email, they replace those previous ones, so maybe it had to do something with that because that one was still showing offline in my list, but for accepting someone else's invitation, the results seems to be same for both attempts.
*** Original post on bio 1572 at 2012-07-11 14:22:30 UTC ***

(In reply to comment #3)
> made some tags visible to find that buddy

I know the "Other contacts" special tags has issues with added contacts. I'm guessing your contact should have appeared in a hidden tag, and so should have been displayed in "Other contacts". Is that guess right?

If this is the bug I have in mind, either showing/hiding again the tag, or restarting Instantbird would make the contact appear.

I'm a bit confused by the part where you said you had to 'delete the cache from profile directory' (comment 0) though.
*** Original post on bio 1572 by Aqeel Zafar <aqeel AT aqeeliz.com> at 2012-07-11 14:49:36 UTC ***

Since my last comment, I have added two more contacts and both of them showed up after restarting Instantbird. So, it is seeming more likely that either I was mistaken or there was some other variable causing the initial issue, which I wasn't able to factor in.

I wasn't able to test the other way though, that is when someone else adds me, so can't say anything about it.
*** Original post on bio 1572 at 2012-08-09 15:04:11 UTC ***

Changing to a UI bug and confirming.
Status: UNCONFIRMED → NEW
Component: XMPP → Contacts window
Ever confirmed: true
Product: Chat Core → Instantbird
Summary: New Gtalk contacts added doesn't show up in Contact list → Contacts added directly to "Other Contacts" don't show until collapsed/expanded
*** Original post on bio 1572 at 2012-08-27 10:16:10 UTC ***

This bug makes Bonjour almost unusable if the user has hidden the "Bonjour" tag.
*** Original post on bio 1572 at 2013-10-16 20:31:29 UTC ***

Marking 1.5 wanted because I hit this way more often now that bug 953891 (bio 451) made adding a contact for an IRC nick trivial. Not sure if we will actually have time to fix it for 1.5 though.
Whiteboard: [1.5-wanted]
Attached patch PatchSplinter Review
*** Original post on bio 1572 as attmnt 2966 at 2013-10-19 16:19:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354747 - Flags: review?(florian)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8354747 [details] [diff] [review]
Patch

*** Original change on bio 1572 attmnt 2966 at 2013-10-19 16:31:57 UTC ***

Thanks! :-)
Attachment #8354747 - Flags: review?(florian) → review+
Whiteboard: [1.5-wanted] → [1.5-wanted][checkin-needed]
*** Original post on bio 1572 at 2013-10-19 22:48:34 UTC ***

Thanks for fixing this!
http://hg.instantbird.org/instantbird/rev/57c3b60e089d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.5-wanted][checkin-needed] → [1.5-wanted]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.