95501 - MLK : (POP3) nsDocShell leaks on start-up, check new mail and shutdown

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Navin Gupta]

This is for only one pop3 acct.

Comment 1

[Navin Gupta]

Attachment: leak log

Comment 2

[Navin Gupta]

Attachment: proposed fix

Comment 3

[Navin Gupta]

The fix is to set the callback to null as we are about to close the socket and 
get rid of the connection. 

Comment 4

[Navin Gupta]

Attachment: leak log after the fix.

Comment 5

[Navin Gupta]

cc bienvenu for review. Since I am making changes to the base class I have 
checked news also and it works fine. I'll do some more testing. 

Comment 6

[David :Bienvenu]

check with mscott, please. He's the master of this stuff. That is great if this
fixes the doc shell, though!

Comment 7

[David :Bienvenu]

If Scott gives you an r=, I'll sr it. 

Comment 8

[Scott MacGregor]

that change looks safe. 
r=mscott

Comment 9

[David :Bienvenu]

sr=bienvenu

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This seems like a pretty low-level change that fixes a rather small leak.
(I'm not even sure it fixes the leak -- it looks to me more like it just
reduces the ownership fanout from a transport that is leaked either way.
That's not necessarily a bad thing -- making leaks smaller is good -- but
I'm not sure it's worth the possible risk for 0.9.4.)  Do you think this
could wait until 0.9.5?

Comment 11

[Navin Gupta]

fix checked in. Note that it may fix docShell leaks  for news because the 
fix is in the base class.

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

Attachment: QA's leaklog (debug win32)

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

verified fixed.