Closed Bug 955038 Opened 10 years ago Closed 10 years ago

Replace "buddy" with "contact" in user-facing strings

Categories

(Instantbird Graveyard :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: benediktp)

Details

(Whiteboard: [1.3-wanted])

Attachments

(1 file, 3 obsolete files)

*** Original post on bio 1608 at 2012-07-26 11:29:00 UTC ***

We sometimes use "buddy" and "contact" to refer to the same thing (as far as the user is concerned). We should decide on one or the other, and I think it was decided it should be "contact".

Most visibly:
- 'Add buddy' menu item and dialog
- 'Show offline buddies'

but probably also various other strings for system messages etc.
Whiteboard: [1.3-wanted]
Summary: Replace mentions of "buddy" with "contact" in user-facing strings → Replace "buddy" with "contact" in user-facing strings
Attached patch WIP (obsolete) — Splinter Review
*** Original post on bio 1608 as attmnt 1974 at 2012-10-17 15:05:00 UTC ***

This WIP includes all occurences of "Buddy" that I could find in the localization files for instantbird/chrome and chat (none here iirc). Entity names weren't changed, i.e. even thought the string mentions a "contact", it might still have a name containing "buddy".
Some changes might not be the best (e.g. command key for "Add Contact" to be "C", which clashes with the copy-shortcut).
*** Original post on bio 1608 at 2012-10-17 15:09:20 UTC ***

Entity names need to be changed anyway so the strings are updated. So...we should just use this time to change them all to "contact". :)
Comment on attachment 8353733 [details] [diff] [review]
WIP

*** Original change on bio 1608 attmnt 1974 at 2012-10-17 15:17:40 UTC ***

>diff --git a/instantbird/locales/en-US/chrome/instantbird/accountWizard.properties b/instantbird/locales/en-US/chrome/instantbird/accountWizard.properties

> topProtocol.prpl-gtalk.description=Talk to your Gmail contacts
> topProtocol.prpl-facebook.description=Communicate with Facebook friends
> topProtocol.prpl-twitter.description=Stay up to date with your Twitter timeline
>-topProtocol.prpl-aim.description=Chat with your buddies on AOL Instant Messenger
>+topProtocol.prpl-aim.description=Chat with your contacts on AOL Instant Messenger

"buddy" is the correct AIM-specific term, so please don't change this string.


>diff --git a/instantbird/locales/en-US/chrome/instantbird/buddytooltip.properties b/instantbird/locales/en-US/chrome/instantbird/buddytooltip.properties

>-buddy.screenname=Buddy
>+buddy.screenname=Contact

This change isn't an improvement, it's still as confusing as before.
We use the "buddy.screenname" tooltip line to show in the tooltip the raw username when the username doesn't match with the display name.

I think I would suggest replacing that string with:
buddy.username=Username


I only looked at the other changes very quickly, but they seemed fine. Thanks for looking at this! :-)
Attachment #8353733 - Flags: feedback+
Attached patch WIP2 (obsolete) — Splinter Review
*** Original post on bio 1608 as attmnt 1976 at 2012-10-17 15:42:00 UTC ***

I included the "username" change for the tooltip, changed some entity names where necessary.

One thing that I don't like is the mixed use of "buddy" / "contact" for entity names now. There are for example "buddy.authRequest.*" entities of which none contained the term "buddy" and therefore weren't needed to change and "contact.deletePrompt.*" (previously "buddy.deletePrompt.*")) which contained it and changed to contact.* now.

I wondered if I also should change id's and command names containing "buddy".
Comment on attachment 8353733 [details] [diff] [review]
WIP

*** Original change on bio 1608 attmnt 1974 at 2012-10-17 15:42:44 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353733 - Attachment is obsolete: true
Comment on attachment 8353735 [details] [diff] [review]
WIP2

*** Original change on bio 1608 attmnt 1976 at 2012-11-03 00:35:01 UTC ***


>diff --git a/instantbird/locales/en-US/chrome/instantbird/addbuddy.dtd b/instantbird/locales/en-US/chrome/instantbird/addbuddy.dtd

>-<!ENTITY addBuddyWindow.title           "Add buddy">
>+<!ENTITY addBuddyWindow.title2          "Add contact">

Why not addContactWindow.title?

Also, isn't the correct en-US way to write this string is "Add Contact"? It's capitalized this way in another place. I think the rule is to capitalize the first letter of all important words for en-US strings.

>diff --git a/instantbird/locales/en-US/chrome/instantbird/instantbird.dtd b/instantbird/locales/en-US/chrome/instantbird/instantbird.dtd

>-<!ENTITY showOfflineBuddiesCmd.label   "Show offline buddies">
>-<!ENTITY showOfflineBuddiesCmd.accesskey "o">
>+<!ENTITY showOfflineContactsCmd.label   "Show offline contacts">

"Show Offline Contacts"? :-)



What's the status of this patch? Is there anything blocking it? Can we hope to have this fixed by early next week (ie before we string freeze for 1.3)?
Attachment #8353735 - Flags: feedback+
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1608 as attmnt 2050 at 2012-11-05 15:52:00 UTC ***

Added the changes. I'm not happy with the new "Add Contact" shortcut key ("Ctrl+C") though.

I've also got another version of this patch that includes more changes in menus.xul and menus.js to use "contact(s)" instead of "budd(y|ies)" in IDs and variable names. This one should only include the requested changes, though.
Attachment #8353810 - Flags: review?(clokep)
Comment on attachment 8353735 [details] [diff] [review]
WIP2

*** Original change on bio 1608 attmnt 1976 at 2012-11-05 15:52:54 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353735 - Attachment is obsolete: true
Assignee: nobody → benediktp
Status: NEW → ASSIGNED
*** Original post on bio 1608 at 2012-11-05 15:55:21 UTC ***

(In reply to comment #6)
> Added the changes. I'm not happy with the new "Add Contact" shortcut key
> ("Ctrl+C") though.
Is Ctrl+A taken?
Comment on attachment 8353810 [details] [diff] [review]
Patch

*** Original change on bio 1608 attmnt 2050 at 2012-11-05 16:42:05 UTC ***

Redirecting to florian.

FWIW, I don't think Ctrl+C will work well though. :(
Attachment #8353810 - Flags: review?(clokep) → review?(florian)
*** Original post on bio 1608 at 2012-11-05 16:47:47 UTC ***

(In reply to comment #7)
> (In reply to comment #6)
> > Added the changes. I'm not happy with the new "Add Contact" shortcut key
> > ("Ctrl+C") though.
> Is Ctrl+A taken?

It's well known as "Select All", so I think we shouldn't use it for something different. (Similar problem for Ctrl+C of course).

I think it's quite common to have command keys that don't match the words used in the menu items (usually command keys aren't even translated; I've never understood why they are in the l10n files...), so keeping the current key (Ctrl+B) may be an acceptable option.
Attached patch Patch v2Splinter Review
*** Original post on bio 1608 as attmnt 2053 at 2012-11-05 17:49:00 UTC ***

The shortcut key is unchanged now (Ctrl+B), I kept the new name for consistency, though.
Attachment #8353813 - Flags: review?
Comment on attachment 8353810 [details] [diff] [review]
Patch

*** Original change on bio 1608 attmnt 2050 at 2012-11-05 17:49:20 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353810 - Attachment is obsolete: true
Attachment #8353810 - Flags: review?(florian)
Comment on attachment 8353813 [details] [diff] [review]
Patch v2

*** Original change on bio 1608 attmnt 2053 at 2012-11-05 17:50:10 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353813 - Flags: review? → review?(florian)
Comment on attachment 8353813 [details] [diff] [review]
Patch v2

*** Original change on bio 1608 attmnt 2053 at 2012-11-05 22:19:34 UTC ***

Thanks!
Attachment #8353813 - Flags: review?(florian) → review+
*** Original post on bio 1608 at 2012-11-06 10:34:44 UTC ***

http://hg.instantbird.org/instantbird/rev/c9b8760d1045
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.