Closed Bug 955041 Opened 10 years ago Closed 10 years ago

Unread ruler movement can cause spurious Bubbles gap time text

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 1611 at 2012-08-01 23:39:00 UTC ***

STR
1) Conv with unread ruler present, with the ruler splitting a bubble.
2) Elapse sufficient time for a gap time text to appear
3) Add some further messages
4) When the ruler is removed, an incorrect gap time text appears under the last message.

Origin: The reinsertion of the first message after the ruler into the split bubble (to unsplit it) is perceived by Bubbles just like any other message insertion. lastInsertTime is set accordingly. But there have been intermediate messages, so this lastInsertTime is incorrect and can be much too old.
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1611 as attmnt 1773 at 2012-08-02 14:07:00 UTC ***

Straightforward fix to the bug in Bubbles that causes this: Don't update the "lastInsertTime" which tracks the last message time if the inserted element is not newer than the previous lastInsertTime.

This will also help for all other instances where HTML elements are inserted outside chronological order in the future (e.g. infinite scroll).
Attachment #8353534 - Flags: review?(florian)
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1611 as attmnt 1774 at 2012-08-02 14:17:00 UTC ***

Removes an obsolete parameter.
Attachment #8353535 - Flags: review?(florian)
Comment on attachment 8353534 [details] [diff] [review]
Patch

*** Original change on bio 1611 attmnt 1773 at 2012-08-02 14:17:41 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353534 - Attachment is obsolete: true
Attachment #8353534 - Flags: review?(florian)
Comment on attachment 8353535 [details] [diff] [review]
Patch

*** Original change on bio 1611 attmnt 1774 at 2012-08-03 13:32:06 UTC ***

I would prefer just calling updateLastInsertTime instead of moving all that code block. Also, please remove the trailing whitespaces you added.
Attachment #8353535 - Flags: review?(florian) → review-
Attached patch PatchSplinter Review
*** Original post on bio 1611 as attmnt 1778 at 2012-08-03 13:41:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353539 - Flags: review?(florian)
Comment on attachment 8353535 [details] [diff] [review]
Patch

*** Original change on bio 1611 attmnt 1774 at 2012-08-03 13:41:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353535 - Attachment is obsolete: true
Comment on attachment 8353539 [details] [diff] [review]
Patch

*** Original change on bio 1611 attmnt 1778 at 2012-08-03 13:47:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353539 - Flags: review?(florian) → review+
*** Original post on bio 1611 at 2012-08-03 18:11:25 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/6ca6cf727c46

Thanks!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.