Closed Bug 955044 Opened 10 years ago Closed 10 years ago

Update the credits for Instantbird 1.2

Categories

(Instantbird Graveyard :: Other, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

Details

(Whiteboard: [1.2-blocking])

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1614 at 2012-08-02 17:49:00 UTC ***

We need to add (see [1]):
aleth
Florian Janßen (FeuerFliege)
Will Nayes (wnayes)
Matt d'Entremont (v17al)

CC'ing everyone to ensure the names are right. (Note that we won't be adding people's handles, just their names.) You can see this currently by going to Help > About > Credits.

[1] https://bugzilla.instantbird.org/buglist.cgi?resolution=FIXED&target_milestone=1.2&list_id=2530
Whiteboard: [1.2-blocking]
*** Original post on bio 1614 at 2012-08-02 17:53:40 UTC ***

Oops. I forgot Varuna Jayasiri (vpj), our Google Summer of Code student from 2011 who originally wrote the JS-XMPP code (but it was cleaned up / checked in by Florian). He doesn't seem to have a Bugzilla account that I can find though.
Attached patch Added the names to credits.xhtml (obsolete) — Splinter Review
*** Original post on bio 1614 as attmnt 1782 at 2012-08-03 21:11:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353543 - Flags: review?(florian)
*** Original post on bio 1614 as attmnt 1785 at 2012-08-04 13:59:00 UTC ***

After discussion on IRC we had previously made decisions not to put nicks in the credits section, so this patch is inline with that policy.
Attachment #8353545 - Flags: review?(florian)
Comment on attachment 8353543 [details] [diff] [review]
Added the names to credits.xhtml

*** Original change on bio 1614 attmnt 1782 at 2012-08-04 13:59:01 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353543 - Attachment is obsolete: true
Attachment #8353543 - Flags: review?(florian)
Comment on attachment 8353545 [details] [diff] [review]
Added the names to credits.xhtml without nicks

*** Original change on bio 1614 attmnt 1785 at 2012-08-04 17:59:54 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353545 - Flags: review?(florian) → review+
*** Original post on bio 1614 at 2012-08-04 18:53:47 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/9aefe3726ef8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.