Closed
Bug 955050
Opened 10 years ago
Closed 10 years ago
If the external protocol service is misconfigured, the thanks page shouldn't load inside the about dialog
Categories
(Instantbird Graveyard :: Other, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
1.02 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1620 at 2012-08-05 20:03:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1620 as attmnt 1793 at 2012-08-05 20:03:00 UTC *** We fixed that for conversations in https://hg.instantbird.org/instantbird/rev/a10138b04637 but missed the credits page. I observed this bug while running an 1.2 rc on my Ubuntu that seemed to be having some issues. I don't think this is worth respinning 1.2 just for it, but if we have to do it for another reason, I think we should take this fix on the 1.2 branch.
Attachment #8353552 -
Flags: review?
Comment 2•10 years ago
|
||
Comment on attachment 8353552 [details] [diff] [review] Fix *** Original change on bio 1620 attmnt 1793 by mook.moz+bugs.instantbird AT gmail.com at 2012-08-05 20:30:34 UTC *** Could use a quick comment (// always prevent default even if loading fails) or something. /me <3 Services.io.newURI(...)
Attachment #8353552 -
Flags: review? → review+
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1620 at 2012-08-21 13:27:48 UTC *** https://hg.instantbird.org/instantbird/rev/70d9a2cf9cbc
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•