95507 - Buttons in the wrong order for send quit dlg

Status: NEW

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Sheela Ravindran]

Build: 2001-08-13-06 win98, linux, mac

Spun off of bug 81314. The dlg that comes up when you want to quit while sending 
mail should have the buttons interchanged to "quit and wait" instead of wait and 
quit. And also the default should be on the button "wait". This was as per 
jennifer's comments in the bug 81314.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Partial patch, but we still need need to make "Wait" the default focused button

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Screenshot, so far.

Comment 3

[Håkan Waara]

No button should be *focused* by default.  Rather, use that button as
default-button.

Do this by simply setting default="true" on that button.

Comment 4

[(not reading, please use [e-mail] instead)]

we can't do default == true, this is common dialog xul.

I think right now that button zero is always the default, so if you flip the 
strings, your first button will be default.

but I might be wrong, I haven't fully investigated.

but if I'm right, we'll need to talk to morse (or who ever owns common dialog) 
about extending it to allow another button (other than button 0) to be the 
default button.

Comment 5

[Stephen P. Morse]

I don't own it although I've used it a lot and extended it when necessary to 
suit my needs.  I'm pretty sure that seth is correct about the first button 
being the default.

Comment 6

[Håkan Waara]

People are adviced to not add nsICommonDialogs usages to the tree. The preferred
new (and embeddable) API is nsIPrompt.  Thanks.

Comment 7

[(not reading, please use [e-mail] instead)]

the code I added already uses the prompt service, I'm not sure what hwaara is
talking about.

to do what I need I could add another argument to confirmEx() which specifies
which button is the default.

http://lxr.mozilla.org/mozilla/source/embedding/components/windowwatcher/public/nsIPromptService.idl

valeski / danm / ccarlen, do you own that interface?

Comment 8

[Håkan Waara]

You talked about "common dialog", so I assumed you meant nsICommonDialogs.

About default buttons: the right button is default, it currently follows the
guidelines on button placements for default buttons etc. íf you want to change
label of a button, do this via JS in your init method.

Comment 9

[Conrad Carlen (not reading bugmail)]

See this comment in the API:
http://lxr.mozilla.org/mozilla/source/embedding/components/windowwatcher/public/nsIPromptService.idl#89
Button #0 is the default button. I think there is an overlay which on Windows
causes the default button to be leftmost. If you show this same dialog on the
Mac, it is the other way around. The Mac behavior is proper WRT the UI
guidelines for the Mac. With Windows, it is also common to have the default
button be leftmost and other buttons to its right. 

Comment 10

[Sheela Ravindran]

As of 2001-12-14-06 This bug still exists

Comment 11

[Arun Prasannan (polar)]

This bug is being marked EXPIRED as it has seen no activity in a very long time.

If you think that the issue reported might still be relevant, please test with a recent release of SeaMonkey and if the problem persists feel free to re-open the report. Thank you.

http://www.seamonkey-project.org/

Comment 12

[Mark Banner (:standard8)]

Bulk reopening incorrectly expired bugs - no activity does not constitute no bug - these need proper checking.

Comment 13

[Stefan [:stefanh]]

How does the dialog look now (2009, sm trunk)?

Comment 14

[Philip Chee]

Attachment: Screenshot 2009 SM-1.9.1

> How does the dialog look now (2009, sm trunk)?

Since the patch in Comment 1 was never checked in I would think that the dialog would look much the same.

Comment 15

[Stefan [:stefanh]]

When I checked on 1.1.16 (mac) there where 3 buttons.

Comment 16

[Philip Chee]

> When I checked on 1.1.16 (mac) there where 3 buttons.
Really? Screenshot please?

Comment 17

[Philip Chee]

The message compose code defines only two buttons, wait and quit:

result = gPromptService.confirmEx(window, promptTitle, promptMsg,
    (gPromptService.BUTTON_TITLE_IS_STRING*gPromptService.BUTTON_POS_0) +
    (gPromptService.BUTTON_TITLE_IS_STRING*gPromptService.BUTTON_POS_1),
    waitButtonLabel, quitButtonLabel, null, null, {value:0});