Closed Bug 955071 Opened 10 years ago Closed 10 years ago

Pressing enter or escape after editing display name or status message causes focus to be lost

Categories

(Instantbird Graveyard :: Contacts window, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: aleth)

Details

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 1642 by James Teh <jamie AT nvaccess.org> at 2012-08-11 16:06:00 UTC ***

Str:
1. Open the main window.
2. Tab to the control to edit the display name.
3. Press enter to begin editing.
4. Press escape.
Expected: Focus should return to the control in step 2.
Actual: Focus is lost and cannot be restored using the keyboard, even if the window is closed and reopened (without exiting).
This also applies to editing the status message. Pressing enter instead of escape in step 4 yields the same result.
Work around: Press tab instead of enter/escape.
*** Original post on bio 1642 at 2012-08-12 21:51:19 UTC ***

This might be part of the same bug:
Austin ‏@AustinNix123
@instantbird When pressing the buttons to change screen name or change status, the program hangs, and I have to exit it 
@instantbird with the task manager. Other than that, I really enjoy the program. It works very well with NVDA, 
@instantbird the screen access program I use.
*** Original post on bio 1642 by James Teh <jamie AT nvaccess.org> at 2012-08-12 22:57:40 UTC ***

Could well be. I guess it could appear like a freeze if you didn't know what to look for. Fwiw, you can get out of this mess by using the object navigation and set focus commands of NVDA to move focus to, say, the contacts list, but many users wouldn't know how/think to do this.
*** Original post on bio 1642 at 2012-08-13 11:00:14 UTC ***

Confirming.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1642 as attmnt 1805 at 2012-08-15 00:01:00 UTC ***

Keeps the correct element focused after the input binding is detached when finishing the editing by pressing Return or Escape.
Attachment #8353564 - Flags: review?(clokep)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8353564 [details] [diff] [review]
Patch

*** Original change on bio 1642 attmnt 1805 at 2012-08-15 00:39:58 UTC ***

I'm going to bounce this review to flo, I don't feel comfortable reviewing this.
Attachment #8353564 - Flags: review?(clokep) → review?(florian)
*** Original post on bio 1642 at 2012-08-15 00:49:54 UTC ***

Isn't there the same issue with the topic editor?
*** Original post on bio 1642 at 2012-08-15 09:45:22 UTC ***

(In reply to comment #6)
> Isn't there the same issue with the topic editor?

Sounds plausible, but in fact I don't see a way to focus anything in the conv-top using only the keyboard (TAB cycles between tabs, the browser, and the input box). That might be a bug in itself.
*** Original post on bio 1642 at 2012-08-15 10:24:18 UTC ***

(In reply to comment #7)
> (In reply to comment #6)
> > Isn't there the same issue with the topic editor?
> 
> Sounds plausible, but in fact I don't see a way to focus anything in the
> conv-top using only the keyboard (TAB cycles between tabs, the browser, and the
> input box). That might be a bug in itself.

I know the tab-focus behavior is a bit broken in the conversation window and I agree that it would be a different bug, my point was: is it *completely* broken after editing the topic? ie can you still use tab to cycle the focus between tabs and the input box after editing the topic?
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1642 as attmnt 1806 at 2012-08-15 11:37:00 UTC ***

That's true. I've added a fix for that.

Maybe the bug reporter would like to comment/file a bug on the (non-)accessibility of the conv-top elements?
Attachment #8353565 - Flags: review?(florian)
Comment on attachment 8353564 [details] [diff] [review]
Patch

*** Original change on bio 1642 attmnt 1805 at 2012-08-15 11:37:16 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353564 - Attachment is obsolete: true
Attachment #8353564 - Flags: review?(florian)
*** Original post on bio 1642 by James Teh <jamie AT nvaccess.org> at 2012-08-16 02:07:50 UTC ***

(In reply to comment #9)
> Maybe the bug reporter would like to comment/file a bug on the
> (non-)accessibility of the conv-top elements?
With a screen reader, it's possible to access these elements using review commands, and since they're not used so often, that isn't an issue for me. However, it might be for someone who is a keyboard-only user but not a screen reader user (or a novice screen reader user).

Often, toolbars aren't tabbable (and doing so in this case would clutter up the tab order), but there's usually an alternative way to access the features they offer; e.g. menus or similar. In this case, there isn't. Since there's no menu bar, I guess the alt/f10 key (on Windows) could focus the toolbar, but that's a bit non-standard.
*** Original post on bio 1642 at 2012-08-17 20:55:05 UTC ***

(In reply to comment #10)
> (In reply to comment #9)
> > Maybe the bug reporter would like to comment/file a bug on the
> > (non-)accessibility of the conv-top elements?
> With a screen reader, it's possible to access these elements using review
> commands, and since they're not used so often, that isn't an issue for me.
> However, it might be for someone who is a keyboard-only user but not a screen
> reader user (or a novice screen reader user).

So is there any way to edit the topic (and to discover how to do it) for screen reader users?
*** Original post on bio 1642 by James Teh <jamie AT nvaccess.org> at 2012-08-19 23:33:37 UTC ***

(In reply to comment #11)
> So is there any way to edit the topic (and to discover how to do it) for screen
> reader users?
For intermediate NVDA users, almost. (I'll file another bug on that shortly.) For other screen readers, I'm less certain.

Nevertheless, it might be nice to have a way to focus the toolbar for keyboard users anyway.
Attached patch PatchSplinter Review
*** Original post on bio 1642 as attmnt 1823 at 2012-08-21 23:00:00 UTC ***

We can do without the aKeepFocused boolean - thanks for the tip!
Attachment #8353582 - Flags: review?(florian)
Comment on attachment 8353565 [details] [diff] [review]
Patch

*** Original change on bio 1642 attmnt 1806 at 2012-08-21 23:00:48 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353565 - Attachment is obsolete: true
Attachment #8353565 - Flags: review?(florian)
Comment on attachment 8353582 [details] [diff] [review]
Patch

*** Original change on bio 1642 attmnt 1823 at 2012-08-21 23:16:52 UTC ***

r=me, assuming you have tested this at least in the blur case, and in another case (and verified that it was still possible to cycle focus with the tab key).
Attachment #8353582 - Flags: review?(florian) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1642 at 2012-08-22 00:15:40 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/0e15080df0ca

Thanks for fixing this aleth. I wonder if James can mark this as verified once new nightlies come out?
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.3
*** Original post on bio 1642 by jamie AT nvaccess.org at 2012-08-28 01:37:35 UTC ***

Verified fixed in version 1.3a1pre (20120827042551).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.