Closed
Bug 955089
Opened 10 years ago
Closed 10 years ago
Remove ifdefs from conversation.xml
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file)
3.77 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1660 at 2012-08-22 11:02:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1660 as attmnt 1828 at 2012-08-22 11:02:00 UTC *** and replace with normal if clauses.
Attachment #8353587 -
Flags: review?(florian)
Comment 2•10 years ago
|
||
Comment on attachment 8353587 [details] [diff] [review] Patch *** Original change on bio 1660 attmnt 1828 at 2012-08-22 11:58:46 UTC *** Looks ok. I wonder if we should also remove all the magic constants used for key codes and use the event.VK_<name> constants instead; that may be for another cleanup bug though :).
Attachment #8353587 -
Flags: review?(florian) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 3•10 years ago
|
||
*** Original post on bio 1660 at 2012-08-23 12:47:32 UTC *** I think this should have been r-, it didn't actually stop preprocessing the file. :( http://lxr.instantbird.org/instantbird/source/instantbird/content/jar.mn#27
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Whiteboard: [checkin-needed]
Comment 4•10 years ago
|
||
*** Original post on bio 1660 at 2012-08-23 14:19:19 UTC *** (In reply to comment #2) > I think this should have been r-, it didn't actually stop preprocessing the > file. :( Fixed by http://hg.instantbird.org/instantbird/rev/912496b195b8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 1660 at 2012-08-23 14:45:17 UTC *** (In reply to comment #2) > I think this should have been r-, it didn't actually stop preprocessing the > file. :( Sorry I forgot about that part.
You need to log in
before you can comment on or make changes to this bug.
Description
•