Closed Bug 955103 Opened 10 years ago Closed 10 years ago

Accesskey for Add-ons manager not localizable

Categories

(Instantbird Graveyard :: Localization, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: benediktp)

References

Details

(Whiteboard: [1.3-wanted])

Attachments

(1 file)

*** Original post on bio 1674 by Alexander L. Slovesnik <unghost AT gmail.com> at 2012-08-27 10:41:00 UTC ***

addonManager.key in /instantbird/locales/en-US/chrome/instantbird/instantbird.dtd is used as accesskey and as commandkey. accesskeys are usually localized, commandkey are not.

This bug has been introduced in http://hg.instantbird.org/instantbird/rev/96d28918a3c8
*** Original post on bio 1674 at 2012-08-27 10:46:41 UTC ***

Confirming.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 954362
Whiteboard: [1.3-wanted]
Summary: addonManager.key in /instantbird/locales/en-US/chrome/instantbird/instantbird.dtd is used as accesskey and as commandkey → Accesskey for Add-ons manager not localizable
Attached patch PatchSplinter Review
*** Original post on bio 1674 as attmnt 1973 at 2012-10-17 13:45:00 UTC ***

This should make the accesskey localizable.
Attachment #8353732 - Flags: review?(clokep)
Assignee: nobody → benediktp
Status: NEW → ASSIGNED
Comment on attachment 8353732 [details] [diff] [review]
Patch

*** Original change on bio 1674 attmnt 1973 at 2012-10-17 13:55:06 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353732 - Flags: review?(clokep) → review+
Whiteboard: [1.3-wanted] → [1.3-wanted][checkin-needed]
*** Original post on bio 1674 at 2012-10-25 12:10:54 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/d43481fa4668

Thanks.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.3-wanted][checkin-needed] → [1.3-wanted]
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.