Closed
Bug 955113
Opened 10 years ago
Closed 10 years ago
Allow logging to be used in non-global scope
Categories
(Chat Core :: General, enhancement)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: bugzilla, Assigned: Mook)
Details
Attachments
(1 file)
1.38 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1685 by Mook <mook.moz+bugs.instantbird AT gmail.com> at 2012-08-30 04:00:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Reporter | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1685 as attmnt 1873 by mook.moz+bugs.instantbird AT gmail.com at 2012-08-30 04:00:00 UTC *** See attached patch; I want to be able to get logging modules (initLogModule) without having the result be attached to the global. For the heck of it, I also made the object optional, so if you feel like it, you can say var {LOG} = initLogModule("pants"); It seemed fine with my light testing, but you probably want to look at it more carefully.
Attachment #8353631 -
Flags: review?(florian)
Comment 2•10 years ago
|
||
Comment on attachment 8353631 [details] [diff] [review] don't getGlobalForObject() *** Original change on bio 1685 attmnt 1873 at 2012-11-04 15:21:06 UTC *** Didn't break anything during my testing. Sorry for the excessive delay here.
Attachment #8353631 -
Flags: review?(florian) → review+
Comment 3•10 years ago
|
||
*** Original post on bio 1685 at 2012-11-05 01:48:43 UTC *** Committed as http://hg.instantbird.org/instantbird/rev/fc623481eab2 Thanks Mook!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
Reporter | ||
Updated•10 years ago
|
Assignee: bugzilla → mook.moz+mozbz
You need to log in
before you can comment on or make changes to this bug.
Description
•