955117 - Windows build failure: mv: cannot stat `fake.lib' : No such file or directory"

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 1689 at 2012-09-05 15:26:00 UTC ***

11:14:37 AM - flo-retina: I suspect appending || true to http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/Makefile.in#116 would fix the Windows onCommit builds
11:18:54 AM - flo: well, we just need to add a "-" at the beginning of the rule, gmake will then ignore the failure
11:18:57 AM - flo: is anybody going to file a bug? :)
11:19:23 AM * clokep_work won't be. ;)

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 1689 at 2012-09-07 10:45:56 UTC ***

I ran into this, appending the || true fixes it though. :)

I don't know what the other option really means, but I'd appreciate if we ensure it works with pymake!

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 1689 at 2012-09-07 12:36:35 UTC ***

The other option is cleaner, it's to replace "mv" by "-mv". Having "-" as a prefix to a command tells gmake to ignore failtures. pymake is supposed to be syntax-compatible with gmake so I believe it will work for pymake too :).

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Patch

*** Original post on bio 1689 as attmnt 1904 at 2012-09-07 18:28:00 UTC ***

- seems to work with pymake too. :)

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8353662 [details] [diff] [review]
Patch

*** Original change on bio 1689 attmnt 1904 at 2012-09-07 21:40:14 UTC ***

Thanks.

Comment 5

[Florian Quèze [:florian]]

*** Original post on bio 1689 at 2012-09-13 12:15:19 UTC ***

http://hg.instantbird.org/instantbird/rev/f556afd49922