955125 - Update /mode command syntax

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1697 at 2012-09-13 13:50:00 UTC ***

To match/reflect the fixes in bug 954973 (bio 1541), at minimum the help string needs changing, possibly the syntax check too.

Comment 1

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1697 as attmnt 1977 at 2012-10-17 19:28:00 UTC ***

There was actually nothing to do here but change the help string. I separated out the channel/user mode syntax to make it clearer what is required for each. This help string does not cover 1) requesting your own user mode, 2) requesting the current channel mode. We don't currently handle the former, and the latter doesn't seem worth explicitly mentioning, as we display the mode on joining etc.

Comment 2

[Patrick Cloke [:clokep]]

*** Original post on bio 1697 at 2012-10-17 19:32:06 UTC ***

(In reply to comment #1)
> 2) requesting
> the current channel mode. We don't currently handle the former, and the latter
> doesn't seem worth explicitly mentioning, as we display the mode on joining
> etc.

This could easily (?) be added to the second part:
%1$S <channel>[ (+|-)<new mode> [<parameter>][,<parameter>]*]: Get, set or unset a channel mode.

Comment 3

[aleth [:aleth]]

Attachment: Patch implementing comment #2

*** Original post on bio 1697 as attmnt 1978 at 2012-10-17 19:40:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 4

[aleth [:aleth]]

Comment on attachment 8353736 [details] [diff] [review]
Patch

*** Original change on bio 1697 attmnt 1977 at 2012-10-17 19:40:40 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8353737 [details] [diff] [review]
Patch implementing comment #2

*** Original change on bio 1697 attmnt 1978 at 2012-10-17 23:09:14 UTC ***

I'm going to r+ this because I think it is OK...but I do wonder if it should be "Set or unset a participant's mode." instead of a "user mode".

Comment 6

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1697 as attmnt 1981 at 2012-10-18 09:50:00 UTC ***

(In reply to comment #4)
> I'm going to r+ this because I think it is OK...but I do wonder if it should be
> "Set or unset a participant's mode." instead of a "user mode".
I think you're right... Carrying forward the r+.

Comment 7

[aleth [:aleth]]

Comment on attachment 8353737 [details] [diff] [review]
Patch implementing comment #2

*** Original change on bio 1697 attmnt 1978 at 2012-10-18 09:50:57 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 8

[aleth [:aleth]]

*** Original post on bio 1697 at 2012-10-18 10:02:58 UTC ***

Umm... don't we in principle need to change the entity of this string as it has changed? But we can't as it's tied to the command name, so...?

Comment 9

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1697 as attmnt 1982 at 2012-10-18 10:08:00 UTC ***

Turns out the help string entities for commands aren't actually fixed. Also changed "participant's mode" to "user's mode" since we use "user" in the other command help strings, so if we wanted to change that we should change them all.

Comment 10

[aleth [:aleth]]

Comment on attachment 8353740 [details] [diff] [review]
Patch

*** Original change on bio 1697 attmnt 1981 at 2012-10-18 10:08:25 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 11

[Patrick Cloke [:clokep]]

Comment on attachment 8353741 [details] [diff] [review]
Patch

*** Original change on bio 1697 attmnt 1982 at 2012-10-18 10:29:44 UTC ***

Doh, of course we need to do that!

Then that leaves the question of whether we should split the help command into two different messages and insert the line break in code. I think I would prefer this way: it should be simpler for localizers.

Comment 12

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1697 as attmnt 1983 at 2012-10-18 10:56:00 UTC ***

Good idea

Comment 13

[aleth [:aleth]]

Comment on attachment 8353741 [details] [diff] [review]
Patch

*** Original change on bio 1697 attmnt 1982 at 2012-10-18 10:56:05 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 14

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1697 as attmnt 1984 at 2012-10-18 11:04:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 15

[aleth [:aleth]]

Comment on attachment 8353742 [details] [diff] [review]
Patch

*** Original change on bio 1697 attmnt 1983 at 2012-10-18 11:04:14 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 16

[Patrick Cloke [:clokep]]

Comment on attachment 8353743 [details] [diff] [review]
Patch

*** Original change on bio 1697 attmnt 1984 at 2012-10-18 11:05:33 UTC ***

Sorry for all the trivial nits. :( Thanks for fixing this!

Comment 17

[Patrick Cloke [:clokep]]

*** Original post on bio 1697 at 2012-10-26 10:19:50 UTC ***

Checked-in as http://hg.instantbird.org/instantbird/rev/5b0db93ecc3f

Thanks! :)