Closed Bug 955126 Opened 10 years ago Closed 10 years ago

NickServ help message eaten for no good reason

Categories

(Chat Core :: IRC, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: clokep)

Details

(Whiteboard: [1.3-blocking])

Attachments

(1 file)

*** Original post on bio 1698 at 2012-09-14 16:36:00 UTC ***

Steps to reproduce:
- Connect an IRC account for a registered nick without setting any password in the UI.
- Send "help" to nickserv.

Expected result:
See help message.

Actual result:
The help message is visible in the debug log, but not in the nickserv conversation.
*** Original post on bio 1698 at 2012-09-14 16:39:23 UTC ***

Did you send this immediately after connecting?

Did you see the messages prompting for your password?
*** Original post on bio 1698 at 2012-09-14 16:43:33 UTC ***

(In reply to comment #1)
> Did you send this immediately after connecting?
> 
> Did you see the messages prompting for your password?

I typed "help" in the private conversation where nickserv asked for my password.
Whiteboard: [1.3-blocking]
Attached patch Patch v1Splinter Review
*** Original post on bio 1698 as attmnt 2029 at 2012-11-02 02:29:00 UTC ***

Looks like we forgot to delete a variable!
Attachment #8353789 - Flags: review?(bugzilla)
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment on attachment 8353789 [details] [diff] [review]
Patch v1

*** Original change on bio 1698 attmnt 2029 at 2012-11-02 16:55:28 UTC ***

Glad this turned out to be a simple bug!
Attachment #8353789 - Flags: review?(bugzilla) → review+
OS: Other → All
Hardware: x86 → All
Whiteboard: [1.3-blocking] → [1.3-blocking][checkin-needed]
*** Original post on bio 1698 at 2012-11-03 04:25:26 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/bc0b3250be66
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.3-blocking][checkin-needed] → [1.3-blocking]
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.