Closed Bug 955132 Opened 10 years ago Closed 10 years ago

Port Bug 787640 - XMPP: Account wizard and account settings window dimension too small, input fields cut off/cropped, port input hidden

Categories

(Instantbird Graveyard :: Account wizard, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

References

()

Details

Attachments

(2 files, 1 obsolete file)

*** Original post on bio 1704 at 2012-09-25 00:01:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch Port v1Splinter Review
*** Original post on bio 1704 as attmnt 1910 at 2012-09-25 00:01:00 UTC ***

See https://bugzilla.mozilla.org/show_bug.cgi?id=787640

This is a simple port, just making the patch apply for the Instantbird UI.
Attachment #8353668 - Flags: review?(florian)
Comment on attachment 8353668 [details] [diff] [review]
Port v1

*** Original change on bio 1704 attmnt 1910 at 2012-09-25 13:45:54 UTC ***

Thanks!
Attachment #8353668 - Attachment is patch: true
Attachment #8353668 - Attachment mime type: application/octet-stream → text/plain
Attachment #8353668 - Flags: review?(florian) → review+
*** Original post on bio 1704 at 2012-09-25 13:57:51 UTC ***

Bonus point if you also port these improvements to the Account properties dialog (account.xul and account.js in instantbird/content/).
Attached patch Account properties dialog v1 (obsolete) — Splinter Review
*** Original post on bio 1704 as attmnt 1927 at 2012-09-28 02:37:00 UTC ***

So...why do we seem to have account(Wizard)?.(js|xul) files that look almost identical? :(

I want my bonus points!
Attachment #8353683 - Flags: review?(florian)
*** Original post on bio 1704 at 2012-09-28 10:18:55 UTC ***

Now you got me really confused. Why do attachment 8353668 [details] [diff] [review] (bio-attmnt 1910) and attachment 8353683 [details] [diff] [review] (bio-attmnt 1927) bitrot each other without attachment 8353683 [details] [diff] [review] (bio-attmnt 1927) containing all the fixes from attachment 8353668 [details] [diff] [review] (bio-attmnt 1910)?

(In reply to comment #3)

> So...why do we seem to have account(Wizard)?.(js|xul) files that look almost
> identical? :(

Because they are only *almost* identical, but not really identical. And yes, code duplication sucks there :(.
I'm sure I wrote down somewhere that this duplication should be cleaned up someday, but I don't remember if it's was in a todo item or in a bug here.
Comment on attachment 8353683 [details] [diff] [review]
Account properties dialog v1

*** Original change on bio 1704 attmnt 1927 at 2012-10-02 20:40:06 UTC ***

r- per comment 4.
Attachment #8353683 - Flags: review?(florian) → review-
*** Original post on bio 1704 as attmnt 1935 at 2012-10-04 20:51:00 UTC ***

This should now apply properly, sorry about that.
Attachment #8353691 - Flags: review?(florian)
Comment on attachment 8353683 [details] [diff] [review]
Account properties dialog v1

*** Original change on bio 1704 attmnt 1927 at 2012-10-04 20:51:49 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353683 - Attachment is obsolete: true
Comment on attachment 8353691 [details] [diff] [review]
Account properties dialog v2

*** Original change on bio 1704 attmnt 1935 at 2012-10-04 23:42:50 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353691 - Flags: review?(florian) → review+
*** Original post on bio 1704 at 2012-10-04 23:48:55 UTC ***

http://hg.instantbird.org/instantbird/rev/94e3a2851bee
http://hg.instantbird.org/instantbird/rev/8c75967e413a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
Depends on: 955148
Blocks: 953960
You need to log in before you can comment on or make changes to this bug.