955135 - Add a memory reporter for glib

Status: RESOLVED FIXED

(Chat Core :: Debug, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1707 at 2012-09-26 22:11:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

*** Original post on bio 1707 as attmnt 1911 at 2012-09-26 22:11:00 UTC ***

This will also force glib to use jemalloc if it wasn't using it already, which seems a good thing.

This patch has ifdefs so that the reporter isn't included on Linux. Blaming the glib memory on libpurple wouldn't make any sense on Linux where the UI is based on GTK (and so uses glib heavily).

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch v2

*** Original post on bio 1707 as attmnt 1912 at 2012-09-26 22:33:00 UTC ***

Moved that new code into a separate purpleMemory.cpp file to not clutter even more the already messy purpleInit.cpp file.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8353669 [details] [diff] [review]
Patch

*** Original change on bio 1707 attmnt 1911 at 2012-09-26 22:33:23 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 4

[Florian Quèze [:florian]]

Attachment: Patch v2

*** Original post on bio 1707 as attmnt 1913 at 2012-09-26 22:34:00 UTC ***

Patch v2, for real this time.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8353670 [details] [diff] [review]
Patch v2

*** Original change on bio 1707 attmnt 1912 at 2012-09-26 22:34:31 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[Florian Quèze [:florian]]

Attachment: Patch v3

*** Original post on bio 1707 as attmnt 1914 at 2012-09-26 22:58:00 UTC ***

Took into account Mook's review comments over IRC. Mook said this new patch looks good.

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8353671 [details] [diff] [review]
Patch v2

*** Original change on bio 1707 attmnt 1913 at 2012-09-26 22:58:14 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 8

[Patrick Cloke [:clokep]]

*** Original post on bio 1707 at 2012-09-26 23:46:43 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/e65c45291ab3

Awesome! :)