Closed Bug 955138 Opened 10 years ago Closed 10 years ago

Unhandled IRC message: 335

Categories

(Chat Core :: IRC, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1710 at 2012-09-27 18:03:00 UTC ***

310 	RPL_WHOISSVCMSG 	Bahamut

Timestamp: 27/09/12 16:52:39
Warning: Unhandled IRC message: :gravel.mozilla.org 335 florian1 reed :is a Bot on Mozilla
Source File: jar:file:///Applications/Instantbird.app/Contents/MacOS/omni.ja!/components/irc.js
Line: 571
Source Code:
irc
*** Original post on bio 1710 at 2012-09-27 18:04:02 UTC ***

Doh, I mixed messages...

335 	RPL_WHOISBOT 	Unreal
Summary: Unhandled IRC message: 310 → Unhandled IRC message: 335
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1710 as attmnt 2194 at 2013-01-16 02:05:00 UTC ***

This sets the whois information, but doesn't display it.

reed still works as a good test for this. :)
Attachment #8353957 - Flags: review?(florian)
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment on attachment 8353957 [details] [diff] [review]
Patch

*** Original change on bio 1710 attmnt 2194 at 2013-01-17 12:43:50 UTC ***

I think we might as well display this - it's informative.
Attachment #8353957 - Flags: review?(florian) → review-
*** Original post on bio 1710 at 2013-01-17 12:45:56 UTC ***

(In reply to comment #3)
> I think we might as well display this - it's informative.
Maybe together with the info from bug 955139 (bio 1711) (when available)?
Attached patch Patch v2Splinter Review
*** Original post on bio 1710 as attmnt 2203 at 2013-01-18 01:28:00 UTC ***

Displays the information for bot too.
Attachment #8353966 - Flags: review?(aleth)
Comment on attachment 8353957 [details] [diff] [review]
Patch

*** Original change on bio 1710 attmnt 2194 at 2013-01-18 01:28:52 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353957 - Attachment is obsolete: true
Comment on attachment 8353966 [details] [diff] [review]
Patch v2

*** Original change on bio 1710 attmnt 2203 at 2013-01-19 10:07:46 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353966 - Flags: review?(aleth) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1710 at 2013-01-19 12:38:00 UTC ***

http://hg.instantbird.org/instantbird/rev/50caf59c0c0f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.4
You need to log in before you can comment on or make changes to this bug.