Closed Bug 955141 Opened 10 years ago Closed 10 years ago

Tab complete code ignores mouse interaction with inputbox

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: aleth)

Details

Attachments

(1 file)

*** Original post on bio 1713 at 2012-09-28 10:51:00 UTC ***

There's an edge case w/ tab complete, assume you're in a room with someone named foobar.

Type: Hey foo how are you?|
Tab complete foo: Hey foo|<tab> how are you? --> Hey foobar| how are you?
Move to the end of the line (with the mouse): Hey foobar how are you?|
Press backspace: Hey foo|

I'd expect: Hey foobar how are you|
Severity: trivial → normal
Summary: Tab complete edge case (backspace error after moving cursor) → Tab complete code ignores mouse interaction with inputbox
Attached patch PatchSplinter Review
*** Original post on bio 1713 as attmnt 1929 at 2012-09-28 12:32:00 UTC ***

This fixes the problem. I'm not sure if we should do something more complicated here though? As the only instance where that would matter would be when the cursor position does not change as a consequence of the mouse click, I did it this way for now.
Attachment #8353685 - Flags: review?(clokep)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8353685 [details] [diff] [review]
Patch

*** Original change on bio 1713 attmnt 1929 at 2012-09-28 13:01:30 UTC ***

This looks fine to me. I can't think of any bad fallout that would happen to this, but Florian should look over this too.
Attachment #8353685 - Flags: review?(clokep) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1713 at 2012-10-01 23:32:32 UTC ***

http://hg.instantbird.org/instantbird/rev/37f6db95d85b

Thanks! :-)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.